Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write utility scripts in ES6 instead of TypeScript #5674

Closed
DonJayamanne opened this issue May 17, 2019 · 1 comment
Closed

Write utility scripts in ES6 instead of TypeScript #5674

DonJayamanne opened this issue May 17, 2019 · 1 comment
Assignees
@DonJayamanne
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@DonJayamanne
Copy link

DonJayamanne commented May 17, 2019 •
edited
Loading

JS code used in build pipeline is written in TS and transpiled into JS.
Now that our code runs against Node 10, we should be able to use ES6.

Problems:

  • We have TS and JS code side by side (confusing)
  • When making changes to TS, the JS MUST be generated and checked into source

Writing plain simple ES6 JS will fix things.

  • We can still get type checks, etc in JS code (typescript does this well)

@microsoft/pyvsc @rchiodo @IanMatthewHuff
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label May 17, 2019
@DonJayamanne DonJayamanne added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label May 17, 2019
@DonJayamanne DonJayamanne self-assigned this May 17, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label May 17, 2019
@brettcannon
Copy link
Member

Fine by me, although I would still rather write the scripts in Python. 😉

@ghost ghost removed the needs PR label Jun 4, 2019
@DonJayamanne DonJayamanne reopened this Jun 4, 2019
@DonJayamanne DonJayamanne mentioned this issue Jan 2, 2020
Merged
@luabud luabud added area-internal Label for non-user facing issues and removed feature-* labels May 13, 2020
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label May 13, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label May 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brettcannon @DonJayamanne @karthiknadig @luabud