Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to telemetry with regards to discovery of python environments #5593

Closed
DonJayamanne opened this issue May 9, 2019 · 1 comment
Closed
Assignees
Labels
feature-request Request for new features or functionality important Issue identified as high-priority

Comments

@DonJayamanne
Copy link

DonJayamanne commented May 9, 2019

sendTelemetryWhenDone(EventName.PYTHON_INTERPRETER_DISCOVERY, promise, undefined, { locator: this.name });

Change above code to capture number of items discovered.
Currently it just indicates the discovery ran to completion without errors, that's it, pretty much useless

Easy change.

@DonJayamanne DonJayamanne added feature-request Request for new features or functionality needs PR important Issue identified as high-priority labels May 9, 2019
@DonJayamanne
Copy link
Author

Prescribed solution:

@brettcannon brettcannon added this to the 2019 - June Sprint 13 milestone Jun 26, 2019
@DonJayamanne DonJayamanne removed this from the 2019 - June Sprint 13 milestone Jul 17, 2019
@DonJayamanne DonJayamanne added this to the 2019 - July Sprint 15 milestone Jul 31, 2019
@karrtikr karrtikr self-assigned this Aug 8, 2019
@ghost ghost removed the needs PR label Aug 15, 2019
@DonJayamanne DonJayamanne reopened this Aug 15, 2019
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Aug 15, 2019
@DonJayamanne DonJayamanne self-assigned this Aug 15, 2019
@DonJayamanne DonJayamanne added needs PR and removed triage-needed Needs assignment to the proper sub-team labels Aug 15, 2019
@ghost ghost removed the needs PR label Aug 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

4 participants