Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass parent debug session to child debug sessions using new DA API #5464

Closed
DonJayamanne opened this issue Apr 24, 2019 · 2 comments
Closed

Pass parent debug session to child debug sessions using new DA API #5464

DonJayamanne opened this issue Apr 24, 2019 · 2 comments
Assignees
@DonJayamanne @karrtikr
Labels
area-debugging feature-request Request for new features or functionality
Milestone
2019 - May Sprint 10

Comments

@DonJayamanne
Copy link

This is required to ensure sub processes are not displayed
@DonJayamanne DonJayamanne added this to the 2019 - April Sprint 9 milestone Apr 24, 2019
@DonJayamanne DonJayamanne added area-debugging needs PR feature-request Request for new features or functionality labels Apr 24, 2019
@DonJayamanne
Copy link
Author

DonJayamanne commented Apr 24, 2019 •
edited
Loading

Prescribed Solution

  • Update src/client/debugger/extension/hooks/childProcessAttachService.ts
    • Pass parent debug session
  • Use new VSC API to debug by passing in the parent session
    • Update IDebugServicec.startDebugging to reflect changes to the underlying VSC API
  • Test sub process debugging and ensure we have just one debug session displayed in debug session UI

@karrtikr karrtikr self-assigned this May 6, 2019
@karrtikr
Copy link

karrtikr commented May 7, 2019 •
edited
Loading

I made the changes, and this the behavior i see. No debug sessions are displayed in debug session UI. (I think it's because there is only one parent debug session, no need to display just one session)

image.png

When setting "debug.showSubSessionsInToolBar": true is set (default value is false), child processes are visible under debug toolbar but are indented.

imgpsh_mobile_save.jpg

@karrtikr karrtikr mentioned this issue May 7, 2019
Merged
4 tasks
@DonJayamanne DonJayamanne self-assigned this May 20, 2019
@ghost ghost removed the needs PR label May 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

@karrtikr karrtikr

Labels
area-debugging feature-request Request for new features or functionality
Projects
None yet
Milestone
2019 - May Sprint 10
Development

No branches or pull requests
3 participants
@ericsnowcurrently @DonJayamanne @karrtikr