Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use jsonc-parser instead of strip-json-comments #4819

Closed
DonJayamanne opened this issue Mar 18, 2019 · 1 comment · Fixed by #7281
Closed

Use jsonc-parser instead of strip-json-comments #4819

DonJayamanne opened this issue Mar 18, 2019 · 1 comment · Fixed by #7281
Assignees
@kimadeline
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue
Milestone
2019 - September ...

Comments

@DonJayamanne
Copy link

DonJayamanne commented Mar 18, 2019 •
edited
Loading

https://www.npmjs.com/package/jsonc-parser
Its the same one used in VSC, hence the reason to use this.
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Mar 18, 2019
@DonJayamanne DonJayamanne added good first issue needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. and removed triage-needed Needs assignment to the proper sub-team labels Mar 18, 2019
@mikeroll mikeroll mentioned this issue Sep 7, 2019
Merged
10 tasks
@kimadeline kimadeline added this to the September sprint 2019.1 milestone Sep 10, 2019
@ghost ghost removed the needs PR label Sep 16, 2019
@kimadeline kimadeline reopened this Sep 16, 2019
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Sep 16, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 16, 2019
@kimadeline kimadeline self-assigned this Sep 16, 2019
@kimadeline
Copy link

Validated, extension still works in Insiders build 2019.9.36496:

  • extension activation
  • debugging: run file in terminal, debug file
  • testing: discovery (using pytest), running
  • symbol renaming, go to definition (using LS)

@ghost ghost removed the needs PR label Sep 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kimadeline kimadeline

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue
Projects
None yet
Milestone
2019 - September Sprint 2
Development

Successfully merging a pull request may close this issue.

Use jsonc-parser instead of strip-json-comments mikeroll/vscode-python
4 participants
@brettcannon @DonJayamanne @gramster @kimadeline