Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change title of Discover Tests to Discovering when discovering tests #4562

Closed
DonJayamanne opened this issue Feb 27, 2019 · 3 comments
Closed

Change title of Discover Tests to Discovering when discovering tests #4562

DonJayamanne opened this issue Feb 27, 2019 · 3 comments
Assignees
@karrtikr
Labels
area-testing feature-request Request for new features or functionality
Milestone
2019 - May Sprint 11

Comments

@DonJayamanne
Copy link

Currently when discovering tests the icon changes to a spinning one, however the tooltip is still Discovery Unit Tests, this should probably read Discovering

@luabud /cc
@DonJayamanne DonJayamanne added feature-request Request for new features or functionality area-testing needs decision labels Feb 27, 2019
@luabud
Copy link
Member

luabud commented Apr 2, 2019

#5001

@luabud luabud added this to the 2019, week 13 - March Sprint 7 milestone Apr 2, 2019
@DonJayamanne DonJayamanne changed the title Change title of Discovery All Unit Tests to Discovering when discovering tests Change title of Discovery Tests to Discovering when discovering tests May 29, 2019
@DonJayamanne DonJayamanne changed the title Change title of Discovery Tests to Discovering when discovering tests Change title of Discover Tests to Discovering when discovering tests May 29, 2019
@DonJayamanne
Copy link
Author

Prescribed solution

  • Change the label in package.json for the following entry:
            {
                "command": "python.discoveringTests",
                "title": "%python.command.python.discoverTests.title%",
                "category": "Python",
                "icon": {
                    "light": "resources/light/discovering-tests.svg",
                    "dark": "resources/dark/discovering-tests.svg"
                }
            },

@ghost ghost removed the needs PR label May 29, 2019
@DonJayamanne DonJayamanne reopened this May 29, 2019
@DonJayamanne DonJayamanne added this to the 2019 - May Sprint 11 milestone May 29, 2019
@karrtikr karrtikr self-assigned this Jun 3, 2019
@karrtikr karrtikr mentioned this issue Jun 3, 2019
Merged
3 tasks
@ericsnowcurrently
Copy link
Member

validated

@ghost ghost removed the needs PR label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-testing feature-request Request for new features or functionality
Projects
None yet
Milestone
2019 - May Sprint 11
Development

No branches or pull requests
4 participants
@ericsnowcurrently @DonJayamanne @karrtikr @luabud