Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conda activation fails when there is a space in the env name #4243

Closed
DonJayamanne opened this issue Jan 31, 2019 · 2 comments
Closed

Conda activation fails when there is a space in the env name #4243

DonJayamanne opened this issue Jan 31, 2019 · 2 comments
Assignees
@karrtikr
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone
2019, week 11 - M...

Comments

@DonJayamanne
Copy link

This is a regression.

How did the tests fail? Or didn't we have any tests with spaces?
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug area-terminal important Issue identified as high-priority labels Jan 31, 2019
@DonJayamanne DonJayamanne removed this from the 2019, week 7 - Feb Sprint 4 milestone Feb 14, 2019
@qubitron qubitron added this to the 2019, week 9 - Feb Sprint 5 milestone Feb 26, 2019
@DonJayamanne DonJayamanne mentioned this issue Feb 27, 2019
Closed
@DonJayamanne
Copy link
Author

DonJayamanne commented Feb 27, 2019 •
edited
Loading

Todo:

  • Fix bug in src/client/common/terminal/environmentActivationProviders/condaActivationProvider.ts
  • Write unit tests

@karrtikr karrtikr self-assigned this Mar 11, 2019
@DonJayamanne DonJayamanne self-assigned this Mar 13, 2019
@ericsnowcurrently
Copy link
Member

I just activated a conda environment with the name "test env". Activation worked fine.

@ericsnowcurrently ericsnowcurrently removed their assignment Mar 18, 2019
@ghost ghost removed the needs PR label Mar 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-terminal bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Milestone
2019, week 11 - March Sprint 6
Development

No branches or pull requests
6 participants
@brettcannon @ericsnowcurrently @DonJayamanne @d3r3kk @karrtikr @qubitron