Running npm install more than once throws exception

[jakebailey]

When running npm i the first time (fresh repo, or after git clean -fdx), things work. Running npm i again throws an exception. This also occurs when you pull the most recent changes and reinstall dependencies without completely resetting everything.

PS C:\Users\jabaile\vscode-python-origin> git clean -fdx
Removing node_modules/
PS C:\Users\jabaile\vscode-python-origin> npm i

> [email protected] install C:\Users\jabaile\vscode-python-origin\node_modules\husky
> node husky install

husky > setting up git hooks
husky > done

> [email protected] postinstall C:\Users\jabaile\vscode-python-origin\node_modules\typemoq
> postinstall-build dist


> [email protected] postinstall C:\Users\jabaile\vscode-python-origin
> node ./node_modules/vscode/bin/install && node ./build/ci/postInstall.js

Detected VS Code engine version: ^1.26.0
Found minimal version that qualifies engine range: 1.26.0
Fetching vscode.d.ts from: https://raw.githubusercontent.com/Microsoft/vscode/4e9361845dc28659923a300945f84731393e210d/src/vs/vscode.d.ts
vscode.d.ts successfully installed!

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

added 2010 packages in 57.068s
PS C:\Users\jabaile\vscode-python-origin> npm i

> [email protected] postinstall C:\Users\jabaile\vscode-python-origin
> node ./node_modules/vscode/bin/install && node ./build/ci/postInstall.js

Detected VS Code engine version: ^1.26.0
Found minimal version that qualifies engine range: 1.26.0
Fetching vscode.d.ts from: https://raw.githubusercontent.com/Microsoft/vscode/4e9361845dc28659923a300945f84731393e210d/src/vs/vscode.d.ts
vscode.d.ts successfully installed!

C:\Users\jabaile\vscode-python-origin\build\ci\postInstall.js:23
        throw new Error('Fix for JupyterLabl file \'settingregistry.d.ts\' failed (pvsc post install script)');
        ^

Error: Fix for JupyterLabl file 'settingregistry.d.ts' failed (pvsc post install script)
    at fixJupyterLabDTSFiles (C:\Users\jabaile\vscode-python-origin\build\ci\postInstall.js:23:15)
    at Object.<anonymous> (C:\Users\jabaile\vscode-python-origin\build\ci\postInstall.js:27:1)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function.Module.runMain (module.js:693:10)
    at startup (bootstrap_node.js:191:16)
    at bootstrap_node.js:612:3
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] postinstall: `node ./node_modules/vscode/bin/install && node ./build/ci/postInstall.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\jabaile\AppData\Roaming\npm-cache\_logs\2019-01-23T19_51_40_458Z-debug.log