Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launch config for attach shows squiggles 'showReturnValue' option #3754

Closed
karthiknadig opened this issue Dec 19, 2018 · 7 comments
Closed
Assignees
Labels
area-debugging bug Issue identified by VS Code Team member as probable bug

Comments

@karthiknadig
Copy link
Member

Environment data

  • VS Code version: 1.30.1
  • Extension version (available under the Extensions sidebar): 2018.12.1
  • OS and version: Any
  • Python version (& distribution if applicable, e.g. Anaconda): Any
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): Any
  • Relevant/affected Python packages and their versions: Any

Expected behaviour

Should not show squiggles and allow setting that option for attach.

Actual behaviour

image

@brettcannon brettcannon self-assigned this Dec 19, 2018
@brettcannon brettcannon added bug Issue identified by VS Code Team member as probable bug needs PR area-debugging and removed triage labels Dec 20, 2018
@brettcannon brettcannon removed their assignment Dec 20, 2018
@DonJayamanne
Copy link

Prescribed solution:

  • Modify package.json to add this
  • Update VSC docs (create issue to get this documented).

@qubitron
Copy link

@karthiknadig can we just have this on by default? Is there a reason we need a setting to disable it?

@karthiknadig
Copy link
Member Author

This can be ON by default.

@DonJayamanne DonJayamanne removed this from the 2019, week 15 - April Sprint 8 milestone Apr 10, 2019
@qubitron
Copy link

@karthiknadig great, but is there a reason we need to provide users with an option to turn it off? An internal setting is fine, it just seems like a very obscure thing to need to surface to users as an option.

@karthiknadig
Copy link
Member Author

We always sort the return values to be first. So, if the setting is not available then users cannot reduce noise in the variables window.

Other IDEs provide this setting:
image

image

@DonJayamanne
Copy link

DonJayamanne commented Apr 17, 2019

Prescribed Solution:

Hardcode the setting showReturnValue when generating the debug configuration to be sent to the DA.

@karrtikr
Copy link

validated

@ghost ghost removed the needs PR label Apr 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-debugging bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

6 participants