Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add column support to mypy #3699

Merged
merged 3 commits into from
Dec 18, 2018
Merged

Add column support to mypy #3699

merged 3 commits into from
Dec 18, 2018

Conversation

erictraut
Copy link

@erictraut erictraut commented Dec 14, 2018 •
edited by brettcannon
Loading

For #3597

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [] Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@brettcannon brettcannon changed the title #3597: Modified mypy linter plugin to support column numbers for repo… Add column support to mypy Dec 14, 2018
@DonJayamanne DonJayamanne self-requested a review December 18, 2018 21:25
@DonJayamanne DonJayamanne self-assigned this Dec 18, 2018
@DonJayamanne DonJayamanne merged commit 7de3383 into microsoft:master Dec 18, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

@DonJayamanne DonJayamanne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erictraut @DonJayamanne @brettcannon @msfterictraut