Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to message displayed when python path is invalid (in launch.json) #3661

Closed
DonJayamanne opened this issue Dec 12, 2018 · 0 comments
Assignees
Labels
area-debugging feature-request Request for new features or functionality important Issue identified as high-priority

Comments

@DonJayamanne
Copy link

DonJayamanne commented Dec 12, 2018

Currently when debugging we validate the python path and display generic message with a tip in the message prompting them to click on status bar.
However, if pythonpath is valid in settings.json but invalid in launch.json, then the status bar would display the python version.

I.e. the message (tip) needs to change accordingly.
Suggestion - Try to determine where python path is invalid, settings.json or launch.json

Change message to: "The Python path in your debug configuration is invalid"
Have a single button: ["Open launch.json']

@DonJayamanne DonJayamanne added feature-request Request for new features or functionality needs PR area-debugging important Issue identified as high-priority labels Dec 12, 2018
@DonJayamanne DonJayamanne changed the title Improvements to message displayed when python path is invalid Improvements to message displayed when python path is invalid (in launch.json) Dec 12, 2018
@d3r3kk d3r3kk assigned d3r3kk and unassigned d3r3kk Dec 27, 2018
@karrtikr karrtikr self-assigned this Jan 14, 2019
@DonJayamanne DonJayamanne self-assigned this Jan 23, 2019
@ghost ghost removed the needs PR label Jan 24, 2019
@DonJayamanne DonJayamanne reopened this Jan 24, 2019
@DonJayamanne DonJayamanne removed their assignment Jan 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-debugging feature-request Request for new features or functionality important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

3 participants