-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Share support #3753
Comments
It doesn't work because of this issue for now: Waiting on feedback from live share team. |
So I can kind of get this to work if I turn off all schemes for our code lens. But then the command actually runs on the remote machine so the user doesn't get any of the benefit of it. This work is going to require much more thinking about this. We probably need to start with a meeting with the liveshare team. They don't publish any sort of API to get our stuff to talk with them. That's the starting point I'd say. Otherwise we'd have to
|
@ronglums do you have any indicators on the priority of this? If it's rather high, I can start looking for who to ping for a meeting. |
@rchiodo let's get the conversation going sooner rather than later.. |
The results of our discussion
|
Live share has an npm called vsls: |
Current status
|
For #3581 Get live share to work when server session already started. Fix problems with closing/reopening on the guest side reusing old results Still to do: - Add telemetry for liveshare sessions - Add functional tests to verify liveshare algorithms (probably do this next) <!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ --> - [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR) - [x] Title summarizes what is changing - [x] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!) - [ ] Has sufficient logging. - [ ] Has telemetry for enhancements. - [x] Unit tests & system/integration tests are added/updated - [ ] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate - [ ] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed)
Closing this in favor of smaller tasks. Work left to do:
|
What is the status of this, is it working now? Would like to use this for remote interviews. At least I have been been able to get the other participant to see the Interactive python window. Code does share a port, and the other person can see the kernal. |
Yes it should be finished now. Both sides need the python extension. Be careful though. The other person can run any python code they want and it runs inside your jupyter kernel. We're thinking about making a 'read-only' mode for the guest so that they can only see the interactive window but can't send cells to it. |
Read only sounds good as well. The kernel gets shared but I can't see the interactive window, and I can connect to the kernel if I go to the shared server so it is close to working. However, trying to run cells on the remote machine give me the message.
It sounds like this is supposed to be working so I can open a ticket if that is best. |
Support live share with Python Interactive window.
This entails
The text was updated successfully, but these errors were encountered: