Enable sub process debugging for Flask and Django as the default behaviour

[DonJayamanne]

No description provided.

[brettcannon]

microsoft/vscode#62972

[DonJayamanne]

Prescribed solution:

Update src\client\debugger\extension\configuration\providers\djangoLaunch.ts. Line 33

• Remove noreload for Django and flask
• Enable subProcess as true as the default setting in code (also if not already provided in launch.json)
• Document subProcess setting on VS Cod docs

[DonJayamanne]

Prescribed solution:

• Use the PR https://github.com/microsoft/vscode-python/pull/5856/files
• The default value for subprocess passed to the debugger should be an experiment:
  • Currently this is hardcoded. The value will need to be based on an experiment.
• See here for values of experiment
• This will be possible only if users get the new debug adapter (I.e. live reloading will be used with the new debug adatper).

Question:

• If user has enabled subprocess, should they fall into the experiment?

[jarshwah]

It's not clear to me if this should currently work by updating the launch file to use subprocess = true. Is an experiment running that allows that to work?

[brettcannon]

@jarshwah #5856 has not landed yet, so it's not a fully supported thing yet. But if you look at the PR you can see what settings to flip and see if it works for your use-case.

[luabud]

Let's not change launch.json, configuration will be modified under the hood. Log that information in the output channel.
Use django, jinja, flask, pyramid as markers.

[luabud]

In the config resolver, check if user is in live reload and new debug adapter experiment, and if any of the launch.configs are detected (django, jinja etc), then add subprocess=true to the in memory config and remove --no-reload/noreload (whatever it is for django or flask) from the args. For flask, also remove --no-debugger. All changes are in https://github.com/microsoft/vscode-python/blob/master/src/client/debugger/extension/configuration/resolvers/launch.ts.

Also add telemetry for when this configuration is changed internally.

[karthiknadig]

To validate this, ensure that you are in DebugAdapterFactory - experiment, PtvsdWheels37 - experiment, and Reload - experiment.

Run a flask app, using the following configuration:

{
      "name": "Python: Flask",
      "type": "python",
      "request": "launch",
      "module": "flask",
      "console": "integratedTerminal",
      "env": {
        "FLASK_APP": "app.py",
        "FLASK_ENV": "development",
        "FLASK_DEBUG": "0"
      },
      "args": [
        "run",
        "--no-reload"
      ],
      "jinja": true
    }

Make sure that the --no-reload is removed from the command line. Also, ensure that the logs contain before and after version of the debug configuration.

[ericsnowcurrently]

(on master) I was able to verify that the launch config is getting updated.

However, it doesn't actually debug anything. I'm guessing this is due to that problem with ptvsd not resolving properly when running the extension through VS Code.

[karthiknadig]

That is correct. This is validated then.