Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move utils from src/utils into src/client/common/utils #2748

Closed
DonJayamanne opened this issue Oct 2, 2018 · 1 comment
Closed

Move utils from src/utils into src/client/common/utils #2748

DonJayamanne opened this issue Oct 2, 2018 · 1 comment
Assignees
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@DonJayamanne
Copy link

All extension files are under src/client.
If we're going to change this it must be done in a consistent manner (i.e. remove client folder completely. However, we then end up with a tonne of folders sitting beside the test directory. Generally this isn't how JS/TS projects are structured).

We have client and server as that' what VSC requires, this may have been fixed since then.

@DonJayamanne DonJayamanne self-assigned this Oct 2, 2018
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Oct 2, 2018
@ericsnowcurrently
Copy link
Member

Thanks for taking care of this and for the explanation. This was my fault. You were out so Derek and I talked about it and the change made sense at the time. :) The premise was that src/utils was common to both src/client and src/server. However, it sounds like src/client is the only one that matters, so moving the directory there sounds good. Thanks again.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

2 participants