Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move back IExperimentalDebuggerBanner to where it was #2195

Closed
DonJayamanne opened this issue Jul 19, 2018 · 7 comments · Fixed by #2212
Closed

Move back IExperimentalDebuggerBanner to where it was #2195

DonJayamanne opened this issue Jul 19, 2018 · 7 comments · Fixed by #2212
Assignees
@DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@DonJayamanne
Copy link

I believe this type was in the debugger folder. Currently its in the common folder.
Its not common.
We need to fix these oddities before things get confusing.
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Jul 19, 2018
@d3r3kk d3r3kk self-assigned this Jul 19, 2018
@d3r3kk
Copy link

d3r3kk commented Jul 19, 2018

This might have something to do with the debugger tests hanging.

@DonJayamanne
Copy link
Author

Unlikely

@DonJayamanne
Copy link
Author

I'll check what causing then to hang.

@d3r3kk
Copy link

d3r3kk commented Jul 19, 2018

Thanks, I'm looking too, but cannot repro on Linux (the debugger tests progress in Linux for some reason, but not in Mac nor Windows). I'm putting together a VM at the moment to try it out on Windows.

@DonJayamanne
Copy link
Author

I thought we confirmed the fact that all was ok, nothing is getting blocked. I can't see any blockages on VSTS!

@d3r3kk
Copy link

d3r3kk commented Jul 19, 2018

You are correct, sir. I was thinking about yesterdays builds. Confirmed for myself. Thanks Don!

@DonJayamanne DonJayamanne assigned DonJayamanne and unassigned d3r3kk Jul 21, 2018
@DonJayamanne
Copy link
Author

@d3r3kk I'm assigning this to myself. Need this done to get #2073 merged

@DonJayamanne DonJayamanne mentioned this issue Jul 21, 2018
Merged
7 tasks
DonJayamanne added a commit that referenced this issue Aug 1, 2018
@DonJayamanne
Moved IExperimentalDebuggerBanner back into a debug dir (#2212)
66e3c18 
Fixes #2195
@lock lock bot locked as resolved and limited conversation to collaborators Aug 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved IExperimentalDebuggerBanner back into a debug dir DonJayamanne/pythonVSCode
3 participants
@brettcannon @DonJayamanne @d3r3kk