Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to definition not working when a function's default arguments includes one or more numbers with underscores #180

Closed
DonJayamanne opened this issue Nov 14, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@DonJayamanne
Copy link

From @ajmichaels on September 19, 2017 8:49

Environment data

VS Code version: 1.6.1
Python Extension version: 0.7.0
Python Version: 3.6.2
OS and version: OSX 10.11.6

Actual behavior

Go to definition doesn't work when a function's default arguments includes one or more numbers with underscores

Expected behavior

A number having underscores should not affect go to definition.

Copied from original issue: DonJayamanne/pythonVSCode#1220

@brettcannon brettcannon added awaiting 1-verification bug Issue identified by VS Code Team member as probable bug labels Nov 14, 2017
@brettcannon brettcannon self-assigned this Jan 11, 2018
@brettcannon brettcannon removed their assignment Jan 11, 2018
@brettcannon
Copy link
Member

I can verify this is a problem:

def foo1(a=1000000):
    pass


def foo2(a=1_000_000):
    pass


def bar():
    foo1()
    foo2()

You can go to definition for foo1 but not foo2.

@MikhailArkhipov
Copy link

MikhailArkhipov commented Feb 13, 2018

6015468

@DonJayamanne
Copy link
Author

@MikhailArkhipov
Go to def doesn't work for foo2

@brettcannon
Copy link
Member

This was fixed as part of our Jedi 0.12.0 upgrade.

@brettcannon brettcannon added this to the May 2018 milestone May 7, 2018
brettcannon added a commit that referenced this issue May 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants