Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debug configuration to match latest PTVSD debug configuration #1719

Closed
DonJayamanne opened this issue May 22, 2018 · 0 comments · Fixed by #1720
Closed

Update debug configuration to match latest PTVSD debug configuration #1719

DonJayamanne opened this issue May 22, 2018 · 0 comments · Fixed by #1720
Labels
area-debugging debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone

Comments

@DonJayamanne
Copy link

DonJayamanne commented May 22, 2018

Broken test due to upstream PTVSD changes:
Note: This isn't a bug in PTVSD. These tests have been designed to ensure VSC is in sync with PTVSD, and now its time to sync.

1) Debugging - Capabilities
       Compare capabilities:
      AssertionError: expected { Object (supportsModulesRequest, supportsConfigurationDoneRequest, ...) } to deeply equal { Object (supportsExceptionInfoRequest, supportsConfigurationDoneRequest, ...) }
      + expected - actual
             "filter": "uncaught"
             "label": "Uncaught Exceptions"
           }
         ]
      -  "supportTerminateDebuggee": true
         "supportsConditionalBreakpoints": true
         "supportsConfigurationDoneRequest": true
         "supportsEvaluateForHovers": true
         "supportsExceptionInfoRequest": true
      
      at Object.<anonymous> (src/test/debugger/capabilities.test.ts:99:45)
      at Generator.next (<anonymous>)
      at fulfilled (out/test/debugger/capabilities.test.js:6:58)
      at <anonymous>
@DonJayamanne DonJayamanne added this to the May 2018 milestone May 22, 2018
@DonJayamanne DonJayamanne self-assigned this May 22, 2018
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-debugging labels May 22, 2018
@DonJayamanne DonJayamanne removed their assignment May 29, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-debugging debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
2 participants