Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create system test to ensure terminal gets activated with pipenv #1523

Closed
DonJayamanne opened this issue Apr 27, 2018 · 1 comment
Closed

Create system test to ensure terminal gets activated with pipenv #1523

DonJayamanne opened this issue Apr 27, 2018 · 1 comment
Assignees
@karrtikr
Labels
area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
2018, week 50 - D...

Comments

@DonJayamanne
Copy link

DonJayamanne commented Apr 27, 2018 •
edited by ericsnowcurrently
Loading

  1. spin up python
  2. write sys.executable to a file
  3. check that string
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-terminal labels Apr 27, 2018
@DonJayamanne DonJayamanne self-assigned this Apr 27, 2018
@DonJayamanne DonJayamanne modified the milestones: May 2018, April 2018 Apr 27, 2018
@brettcannon brettcannon modified the milestones: April 2018, May 2018 Apr 30, 2018
@DonJayamanne DonJayamanne modified the milestones: May 2018, June 2018 May 23, 2018
@brettcannon brettcannon removed this from the June 2018 milestone Jun 4, 2018
@brettcannon brettcannon changed the title Create unit test to ensure terminal gets activated with pipenv Create system test to ensure terminal gets activated with pipenv Sep 19, 2018
@DonJayamanne DonJayamanne removed their assignment Oct 10, 2018
@DonJayamanne
Copy link
Author

You might want to look at https://github.com/Microsoft/vscode-python/blob/master/src/test/smoke/runInTerminal.smoke.test.ts

@brettcannon brettcannon assigned karrtikr and unassigned karrtikr Nov 29, 2018
This was referenced Dec 6, 2018
Closed
Merged
@ghost ghost removed the needs PR label Jan 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
2018, week 50 - Dec sprint 2
Development

No branches or pull requests
3 participants
@brettcannon @DonJayamanne @karrtikr