Support opening a .ipynb from azure storage

[IanMatthewHuff]

It think this is just a one line change. Currently our opening code looks for only file and vsls schemes. This was to prevent us from opening something like git diffs for ipynb. Should be a quick change to support this, but I'm not actually sure how to test this. Just need to make the fix quick and pass off a vsix to Sid to test.

Email Details below

Eric,

Thanks for the info. That highlights the issue right there for us. At least until VS Code custom editor support releases we are opening .ipynb files with a bit of a hack. We’re hooking any new files that open up and specifically looking for .ipynbs, then we close down the raw json that was opened up by VSCode and we open up our custom editor. We were having problems with the git diff view trying to open up JSON diffs, so we restricted our viewer to just the “file” and “vsls” schemes (the diff views open up with a “git” scheme). I’m guessing that just adding in azurestorage scheme should unblock this.

Sid and I will test it out. Thanks again,

Ian

From: Eric Jizba [email protected]
Date: Friday, April 17, 2020 at 12:31 PM
To: Sid Unnithan [email protected], Matt Hernandez [email protected], Ian Huff [email protected], Will Lorey [email protected]
Subject: Re: Editing .ipynb files from the Azure Storage extension

Honestly this kind of bug doesn’t surprise me. We use VS Code’s FileSystemProvider api to provide a virtual file system with scheme “azurestorage”, but that API doesn’t seem to be as fully supported as we originally hoped. In some cases, VS Code explicitly filters out schemes other than the normal “file://” - other times it’s less clear what the problem is

[greazer]

Consider black-listing schemes we don't support instead of white-listing those we do.

[IanMatthewHuff]

Validating per conversation with Sid below. Opened up microsoft/vscode-python#12131 to track the node-fetch issue.

[10:18 AM] Sid Unnithan
Hey Ian sorry for not explaining it properly yesterday
​[10:19 AM] Sid Unnithan
I was able to open a file from the share and edit / save it smoothly
​[10:20 AM] Sid Unnithan
However when I tried to run cells I was never able to connect to Jupyter
​[10:24 AM] Ian Huff
Yeah, must be some assumption that we are making about the location of the file I would assume.
​[10:32 AM] Sid Unnithan
Rich was saying that it was because the AzureStorage extension is interfering with our communication
​[10:32 AM] Sid Unnithan
They've patched node-fetch and its breaking our extension