Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto save configuration for ipynb notebook files #2097

Closed
deepaksood619 opened this issue Mar 29, 2020 · 5 comments
Closed

Auto save configuration for ipynb notebook files #2097

deepaksood619 opened this issue Mar 29, 2020 · 5 comments
Assignees

Comments

@deepaksood619
Copy link

Feature: Notebook Editor, Interactive Window, Python Editor cells

Description

I have enabled AutoSave onFocusChange globally in vscode preferences, but jupyter notebook ipynb files don't auto save. Have to explicitly save files everytime after a change. I have lost some work because of these, because I am not in habit of saving, since of my global auto save configuration.

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

@DavidKutu
Copy link

Thanks for the feedback @deepaksood619.
We do have some limitations since we use a web view and we're not editing the file directly, but maybe we can find a solution. We'll discuss this on triage.

@greazer
Copy link
Member

greazer commented Apr 2, 2020

Seems like it could be a regression.

@rchiodo rchiodo assigned rchiodo and unassigned rchiodo Apr 6, 2020
@rchiodo
Copy link
Contributor

rchiodo commented Apr 8, 2020

This only seems to repro if I switch to something that isn't a TextDocument (or off to a different app). Not sure we can detect those two cases. Investigating.

@rchiodo
Copy link
Contributor

rchiodo commented Apr 8, 2020

Okay I can fix switching to other apps and other windows, but not switching to menus. So we can fix this mostly but not behaving exactly like a python file. At least not until VS code supports notebooks natively.

@IanMatthewHuff IanMatthewHuff self-assigned this Apr 10, 2020
@IanMatthewHuff
Copy link
Member

Validated. Both onFocusChange and onWindowChange now worked for ipynb files.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 18, 2020
@microsoft microsoft unlocked this conversation Nov 13, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants