Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling "Python-Terminal-Activate Environment" also disabled Data Science features #2220

Closed
xq114 opened this issue Feb 29, 2020 · 4 comments
Assignees

Comments

@xq114
Copy link

xq114 commented Feb 29, 2020

Bug: Notebook Editor, Interactive Window, Editor cells

image

Steps to cause the bug to occur

  1. Disable Terminal-Activate Environment in Settings
  2. open a .ipynb file/open interactive window

Actual behavior

The extension can't detect ipykernel, and keeps reporting "kernelspec not found"

Expected behavior

Data Science feature should always use the activated environment whether or not the setting item is enabled. From my perspective, I disabled the item for a better console experience(faster and more flexible), while not willing to see jupyter notebook feature disabled.

Your Jupyter and/or Python environment

Please provide as much info as you readily know

  • Jupyter server running: Local
  • Extension version: 2020.2.64397
  • VS Code version: 1.42.1
  • Setting python.jediEnabled: true
  • Python and/or Anaconda version: 3.7.6, conda 4.8.1
  • OS: Windows
  • Virtual environment: conda

Developer Tools Console Output

not relevent

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

@DavidKutu
Copy link

Thank you for reporting this @xq114.

I've been trying it and can't repro the issue. I can run conda on the terminal, open the interactive window, and notebooks.

I can't read the error on the terminal you're sharing, but is it the "‘conda’ is not recognized as an internal or external command" error? If it is, did you add conda to your PATH?

@xq114
Copy link
Author

xq114 commented Mar 3, 2020

Thanks for comment.

Actually I didn't add conda to my path since I have another python install on my computer and I don't want to mix them up. Moreover, conda init will give rise to considerable delay every time I start PowerShell. (That's the default settings after merely installing Anaconda 2019.10)

In the picture 'conda activate base' is automatically inputted to my shell when the option Python-Terminal-Activate Environment is selected. That's the reason why I disabled the option. I'm used to activating the environment via a shell script by myself.

Even though, I find it working when I select the option Python-Terminal-Activate Environment and start a jupyter notebook. It's definitely a great feature. What confused me was that this feature did work only if the certain option was selected, while the option appeared to have nothing to do with the Jupyter Notebook.

Note: to reproduce the issue, one may restart VS code after disabling the option.

@DavidKutu
Copy link

Looks like we are not activating correctly without the setting. We'll get to it shortly.

@DonJayamanne DonJayamanne self-assigned this Apr 15, 2020
@rchiodo
Copy link
Contributor

rchiodo commented Apr 21, 2020

Validated. Can run with this setting turned off. Will end up in our May release

@rchiodo rchiodo closed this as completed Apr 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2020
@microsoft microsoft unlocked this conversation Nov 13, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants