Extra info now checks doc #424
Conversation
|
Hi @abarisain, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
This will possibly break if Println's documentation ever changes
| standard output. Spaces are always added between operands and a newline | ||
| is appended. It returns the number of bytes written and any write error | ||
| encountered. | ||
| ` |
There was a problem hiding this comment.
Not sure I really like how templates strings break indentation, but it does not destroy the file's column count that way
|
The only failing tests are gometalinter's |
|
+1 I tested it locally and it works great. I believe that's the expected behavior and the way it works when editing TS. |
| let hover = new Hover({ language: 'go', value: text }); | ||
| let hoverTexts = []; | ||
| if (definitionInfo.doc != null) { | ||
| hoverTexts.push({ language: null, value: definitionInfo.doc}); |
There was a problem hiding this comment.
I think that passing this as a string will format in a slightly different way which matches what other extensions do: https://github.com/Microsoft/vscode/search?utf8=%E2%9C%93&q=%22new+Hover%22
There was a problem hiding this comment.
Sorry about that, didn't notice that there was a simple string constructor for this
|
Thanks for this - big improvement. |
|
Thanks for merging :) |
This patch enables godoc provided documentation on function hover.
I have no idea why this was implemented but not enabled. Was there any reason?
This may not be desirable since it runs two programs on hover, and can be improved in a followup PR to use gogetdoc. That said, these processes are called everytime the developer writes a function call, which happens (at least for me) way less often than hovering a method.
It's also better than the documentation on parenthesis open, since it is not truncated.
Note that this does not enable the godoc in resolveCompletionItem, that may come in another PR :)
Fixes #87