-
Notifications
You must be signed in to change notification settings - Fork 645
Conversation
go: | ||
- 1.10.x | ||
- 1.11.x | ||
- 1.12.x | ||
- 1.13.x | ||
- tip | ||
|
||
git: | ||
depth: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only clone the most recent commit. This saves a few seconds of CI time.
os: | ||
- osx | ||
- linux | ||
|
||
before_install: | ||
# Call xvfb directly on linux runs and give it time to start | ||
- if [ $TRAVIS_OS_NAME == "linux" ]; then | ||
- if [[ $TRAVIS_OS_NAME == "linux" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[[
is a bash best practice.
- go get -u -v github.com/uudashr/gopkgs/cmd/gopkgs | ||
- go get -u -v github.com/zmb3/gogetdoc | ||
- go get -u -v golang.org/x/lint/golint | ||
- go get -u -v golang.org/x/tools/cmd/gorename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the checks for Go 1.8, which we're not testing anymore. I also sorted this list.
Use the latest Ubuntu VM available (18.04). Only clone the most recent commit. Speeds up cloning. Remove references to Go 1.8. Sort long list of `go get` commands.
@@ -1,25 +1,28 @@ | |||
language: go | |||
|
|||
dist: bionic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run on an Ubuntu 18.04 VM. This is the latest Ubuntu currently offered by Travis.
matrix: | ||
allow_failures: | ||
- go: tip | ||
|
||
sudo: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This used to be the way to specify that you want to run in a container, but this has been deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @y0ssar1an, these are some good catches!
It looks like this is your first PR contribution to this project, Thanks & Welcome!
changes
go get
commands