This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Add support for multiple environment files #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks like gogetdoc isn't happy on osx 1.11.x test, but not sure it's related to my PR |
quoctruong
reviewed
May 6, 2019
package.json
Outdated
| ], | ||
| "items": { | ||
| "type": "string" | ||
| }, | ||
| "description": "Absolute path to a file containing environment variable definitions.", |
There was a problem hiding this comment.
The description should be updated to reflect the fact that both string and array are supported now.
There was a problem hiding this comment.
I've added a better description
|
@quoctruong I've made the suggested changes. |
|
Apologies for not getting to this sooner @SteelPhase There have been a lot of changes to the |
ramya-rao-a
approved these changes
Jan 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've attempted to resolve the issue presented in #1746. I'm sure some things will need to match coding standards and etc, but this initial implementation appears to work with a single file, and an array of many files.