This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Make 'Find All References' Work with Text Selection #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
approved these changes
Jan 7, 2019
|
@richardatphilo, Looks like this is your first PR in this project, Thanks & Welcome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a minor annoyance: When you highlight an identifier in the editor using text selection, using 'Find All References' will return 0 results. This is because the position parameter passed to the provideReferences function will refer to the end of the selection, and guru apparently will not consider the token immediately behind the byte offset.
The extension already defines a custom wordPattern for Go syntax, and the provideReferences function uses this via document.getWordRangeAtPosition to do a sanity check on the position. This change just uses the position at the start of the word range instead of the parameter passed to provideReferences. This enables 'Find All References' to work with text selection (or when the cursor is immediately after an identifier).