Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

go.toolsGopath doesn't expand ${env:GOPATH} #1732

Closed
sphawk opened this issue Jun 15, 2018 · 5 comments
Closed

go.toolsGopath doesn't expand ${env:GOPATH} #1732

sphawk opened this issue Jun 15, 2018 · 5 comments

Comments

@sphawk
Copy link
Contributor

sphawk commented Jun 15, 2018

go.toolsGopath doesn't expand ${env:GOPATH}
I'm using ms-vscode.go v0.6.82

reproduce step

  1. create .vscode/setting.json

{
"go.gopath": "${env:GOPATH};${workspaceFolder}",
"go.toolsGopath": "${env:GOPATH}"
}

  1. press ctrl + shift + p, select Go: Install/Update Tools
@ramya-rao-a
Copy link
Contributor

PRs are welcome to enable both go.gopath and go.toolsGopath settings to honor the env var

The env var should be available in process.env['GOPATH'].

@sphawk
Copy link
Contributor Author

sphawk commented Jun 19, 2018

ok, I'll do it within a few days.

@sphawk
Copy link
Contributor Author

sphawk commented Jun 21, 2018

@ramya-rao-a I created pull request #1743, could you check it please?

@ramya-rao-a
Copy link
Contributor

Hey @sphawk,

Am a little busy with work at the moment, will definitely get to this by the end of the week.

@ramya-rao-a
Copy link
Contributor

This feature is now available in the latest update to the Go extension (0.7.0)
Thanks to @sphawk!

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants