Method signature highlighting incorrect parameter when commas inside string

[cassiobock]

When I type commas inside a string parameter, the current highlighted parameter changes. I tested using a JS file and it didn't happened. Disabling all extensions except this one didn't fixed the issue as well.

Sample code

strings.Replace(",,,")

Image

[ramya-rao-a]

Nice catch!

We use commas to determine how many of the parameters are already typed in. Looks like we end up counting commas even when they are inside a string.

PRs are welcome to fix this bug.

The fix should go here: https://github.com/Microsoft/vscode-go/blob/0.6.80/src/goSignature.ts#L92
To get started, see https://github.com/Microsoft/vscode-go/wiki/Building,-Debugging-and-Sideloading-the-extension-in-Visual-Studio-Code

[cassiobock]

Hi @ramya-rao-a,

Thanks for the heads up. I will definitely take a look later today.

[lggomez]

@cassiobock are you still working on this or I am free to take a look at it?

[cassiobock]

Hey @lggomez, feel free to take a look.

[ramya-rao-a]

The latest beta version (0.9.3-beta.2) of this extension has the fix for this issue

[ramya-rao-a]

The fix for this issue is out in the latest release(0.10.0) of the Go extension