-
Notifications
You must be signed in to change notification settings - Fork 645
High CPU during go vet #1215
Comments
Well... I don't have a clue here especially because you also mention that you can repro this with a simple hello world program! You have autosave enabled, so that would trigger vet for every save. Until the problem is fixed, you can set |
I have the same issue, it seems that I've run a
|
Ok, I guess I found the cause of this: I had a tab opened with a I think that |
It seems that vet also scans the vendor tree and I have a pretty large vendor which makes it very sluggish. When I save I see several
Shouldn't it just run |
Perhaps |
@dahankzter Have you set The only reason we use When you say that |
Yes I have not set any specific config other than default and I really want as much as I can get on save but it needs to be fast enough for it to not lag. |
How does |
It is also fast. |
@dahankzter Thanks I have made a few tweaks
I'll release an update next week, until then can you try out the changes and give feedback? All you have to do is:
|
Great, I will try it out asap!
…On Sun, 12 Nov 2017, 20:56 Ramya Rao, ***@***.***> wrote:
Closed #1215 <#1215>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1215 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAKcU98IKIsfex4hGqP0BdsvocrBHPofks5s101ggaJpZM4PYm3_>
.
|
I see no lagging at all with the latest extension! Thanks for this! |
The perf improvements mentioned in #1215 (comment) are now out in the latest update to the Go extension (0.6.69) |
Cool, when is this published? I seem to be still on 0.6.67 |
Somehow reinstalling the plugin worked but the "update available" had not s tarted to show. Could it be because I installed it manually? |
That shouldn't be the case. For now, uninstall and install it again, you should get the latest. |
That seems to have worked,thx! |
From what I can tell, "go tool vet ." and "go vet ./..." should actually behave the same, recursively process all packages at or below the current directory. I installed the update and performance is definitely better, I just can't tell why. If I run those two commands from the terminal they both do the same thing, and take the same amount of time to complete. But with the extension on save, it goes by really quick. I feel like something else is going on there. |
Packages yes but not vendor right? |
In this case I have no vendor source. According to the go docs vendor source is skipped when using ... wildcards. |
I have read back and forth before but it was a super clear difference now. |
@jnewmoyer |
The alternative was |
Yes, but |
Hi team,
Not sure if this is related to #1035 but whenever I save and go vet kicks in, my CPU seems to indefinitely spin at ~45% CPU for each instance of vet.exe. When I say each instance, there's a new instance of vet.exe spun up per save as well (until my PC grinds to a halt that is).
Any ideas on why this might be? It doesn't seem to be affected by the source it's trying to process either, I'm able to reproduce with a simple hello world program!
Here's some info for you:
Basics:
OS: Windows 10
Go version: go1.8 windows/amd64
Version: 1.16.1
Commit: 2749...
Shell: 1.7.3
Renderer: 58.0.3029.110
Node: 7.9.0
Arch: ia32
Settings:
Extensions:
Go: 0.6.65
Please let me know if there's anything else I can provide to help diagnose.
Cheers,
Rob
The text was updated successfully, but these errors were encountered: