Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earlier validation of Docker .NET Core configuration #747

Merged
merged 8 commits into from
Feb 14, 2019

Conversation

philliphoff
Copy link
Member

Adds earlier validation of certain Docker .NET Core debug configuration properties. If not validated upon the start of debugging, incorrectly specified properties could cause later processes to fail with error messages that are not intuitive.

Also resolves an issue (unlinking a file that does not exist) that caused a failure (i.e. incorrect configuration property) to generate a secondary error message that was even less intuitive than the original.

@philliphoff philliphoff requested a review from a team as a code owner January 16, 2019 23:53
@philliphoff
Copy link
Member Author

This should help in cases such as #742.

@philliphoff philliphoff merged commit d6a526a into master Feb 14, 2019
@philliphoff philliphoff deleted the philliphoff-validation branch February 14, 2019 23:47
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants