Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ${workspaceFolder} in dockerRun/Volumes localPath and containerPath #785

Closed
xstof opened this issue Feb 5, 2019 · 2 comments
Assignees

Comments

@xstof
Copy link

xstof commented Feb 5, 2019

Issue: Currently, there seems to be no support for ${workspaceFolder} when configuring volume mappings in localPath or containerPath. The error is

docker: Error response from daemon: create ${workspaceFolder}/.devcerts: "${workspaceFolder}/.devcerts" includes invalid characters for a local volume name

Example:

"dockerRun": {
                "volumes": [
                    {
                        "localPath": "${workspaceFolder}/.devcerts",
                        "containerPath": "/.devcerts",
                        "permissions": "rw"
                    }
                ]
            }

Use case: when mapping a drive into an ASP.NET Core container containing certificates for development in order to enable SSL. These certs could be stored in the local workspace and mapped this way, without having to hardcode the full path. (The full path might vary depending on who checks out the source.)

Plugin version: plugin was built from master at commit a45a9a6601cf7b17cc3f2cc2ad16db339ba13a49

@philliphoff
Copy link
Member

@xstof Is there a specific use case for using ${workspaceFolder} in the containerPath property in addition to localPath? I would think that the container file system should be fairly independent of the user's workspace.

@xstof
Copy link
Author

xstof commented Feb 12, 2019

That makes perfect sense to me; I don't quite see the use case for that either.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants