Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding C++ template #644

Merged
merged 12 commits into from
Dec 5, 2018
Merged

Adding C++ template #644

merged 12 commits into from
Dec 5, 2018

Conversation

robotdad
Copy link
Member

Proposed change for #570

@robotdad robotdad requested a review from a team as a code owner November 22, 2018 00:24
StephenWeatherford
StephenWeatherford requested changes Nov 26, 2018
View reviewed changes
configureWorkspace/config-utils.ts Outdated
@@ -9,6 +9,18 @@ import { IAzureQuickPickItem, IAzureUserInput } from 'vscode-azureextensionui';
import { ext } from "../extensionVariables";
import { Platform, PlatformOS } from '../utils/platform';

export type OS = 'Windows' | 'Linux';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these and instead use the ones from platform.ts (where they were moved to)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done. The PlatformOS type from platform.ts was already being used so that shouldn't have still been there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies to the extra Platform enum as well... Thx.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Fixed.

@robotdad
removing unused type
3250909 
Unneeded type, already using PlatformOS from platform.ts
@StephenWeatherford
Copy link
Contributor

Regarding the lint error:

ERROR: (ordered-imports) D:/a/1/s/configureWorkspace/configure.ts[20, 1]: Import sources within a group must be alphabetized.

Looks alphabetized to me...? But you can try this:

npm run lint-fix

If it's still giving you problems, let me know and I'll take a look.

@StephenWeatherford
Copy link
Contributor

Looks good, thanks! I'd like to play with it a little bit before merging...

@robotdad
Copy link
Member Author

I threw a hello world in this repo to save you some typing on getting a C++ app to try this with.
https://github.com/robotdad/helloworld

@StephenWeatherford
Copy link
Contributor

Thanks!

@StephenWeatherford
Copy link
Contributor

Looks great, thanks! Next release should be out very soon.

@StephenWeatherford StephenWeatherford merged commit df5dcc5 into microsoft:master Dec 5, 2018
@StephenWeatherford StephenWeatherford mentioned this pull request Dec 13, 2018
Closed
@StephenWeatherford StephenWeatherford mentioned this pull request Jan 24, 2019
Closed
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephenWeatherford StephenWeatherford StephenWeatherford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robotdad @StephenWeatherford