Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose Down/Up can't run on edit file. #302

Closed
jp311 opened this issue Jul 8, 2018 · 5 comments
Closed

Compose Down/Up can't run on edit file. #302

jp311 opened this issue Jul 8, 2018 · 5 comments
Assignees

Comments

@jp311
Copy link

jp311 commented Jul 8, 2018

Console OUTPUT:

Cannot read property 'length' of undefined: TypeError: Cannot read property 'length' of undefined
at C:\Users\jiangp01.vscode\extensions\peterjausovec.vscode-docker-0.0.27\out\commands\docker-compose.js:55:56

That's right on EXPLORER.

VSCode: 1.25.0
Docker: 0.0.27

@StephenWeatherford
Copy link
Contributor

@jp311 Could you please provide more details of what you are doing? Thanks.

@jp311
Copy link
Author

jp311 commented Jul 13, 2018

42685116-bcd0ece6-86c4-11e8-9eda-8d67642f7747

@Enqueuing
Copy link

Enqueuing commented Jul 24, 2018

Also running into this behaviour.

When right-clicking on the main edit pane while editing a docker-compose.yml file and selecting the Compose Up or Compose Down options from the popup menu, nothing happens. After opening developer tools, two errors are generated:
[PeterJausovec.vscode-docker]Cannot read property 'length' of undefined

and

TypeError: Cannot read property 'length' of undefined

Right-clicking the file in the explorer file tree and doing the same Compose up or Compose down works fine. It is only when doing it via the editor window that it fails.

@StephenWeatherford
Copy link
Contributor

@PrashanthCorp Can you repro?

PrashanthCorp added a commit that referenced this issue Jul 24, 2018
and dockerComposeFileURI correctly
Fixes #302.
PrashanthCorp added a commit that referenced this issue Jul 25, 2018
…rComposeFileURI correctly (#326)

* docker-compose: Handle existence of selectedComposeFileURIs
and dockerComposeFileURI correctly
Fixes #302.

* Remove redundant check

* docker-compose: Handle command palette execution.
@StephenWeatherford
Copy link
Contributor

@jp311 Just wanted to let you know that we have published a new version of the Docker extension that should contain this fix. Happy coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants