Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename variable/parameter definition doesn't work if you don't rename double quotes #63

Closed
StephenWeatherford opened this issue Apr 13, 2018 · 2 comments
Closed

Rename variable/parameter definition doesn't work if you don't rename double quotes #63

StephenWeatherford opened this issue Apr 13, 2018 · 2 comments
Labels
P1
Milestone
0.5.0 (webpack)

Comments

@StephenWeatherford
Copy link
Contributor

  1. Try renaming a variable
    !) The prompt includes the quotes
    image

  2. Change the name (leaving the quotes alone)
    image

!) The references end up with quotes
image

If you remove the quotes in the prompt, it works correctly
@StephenWeatherford StephenWeatherford changed the title Rename variable includes quotes in prompt and adds those to renamed references if you don't remove them Rename variable/parameter definition includes quotes in rename Apr 13, 2018
@StephenWeatherford
Copy link
Contributor Author

Also works correctly if you rename a reference, not a definition

@StephenWeatherford StephenWeatherford added this to the 0.4.1 milestone Apr 18, 2018
@StephenWeatherford StephenWeatherford modified the milestones: 0.4.1, 0.4.2 Apr 27, 2018
@PrashanthCorp PrashanthCorp self-assigned this May 15, 2018
@StephenWeatherford StephenWeatherford modified the milestones: 0.4.2, 0.4.3 May 16, 2018
@StephenWeatherford
Copy link
Contributor Author

vscode controls what goes into the rename prompt, so we can't automatically remove the quotes there. But we can ignore quotes if they're given to us.

@StephenWeatherford StephenWeatherford added P1 and removed P2 labels Feb 14, 2019
@StephenWeatherford StephenWeatherford mentioned this issue Feb 23, 2019
Merged
@StephenWeatherford StephenWeatherford changed the title Rename variable/parameter definition includes quotes in rename Rename variable/parameter definition doesn't work if you don't rename double quotes Feb 23, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P1
Projects
None yet
Milestone
0.5.0 (webpack)
Development

No branches or pull requests
2 participants
@StephenWeatherford @PrashanthCorp