Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the reference icons when opening references #623

Closed
wants to merge 1 commit into from
Closed

Keep the reference icons when opening references #623

wants to merge 1 commit into from

Conversation

dungpa
Copy link
Contributor

@dungpa dungpa commented Sep 8, 2015

Close #559.

@forki
Copy link
Contributor

forki commented Sep 8, 2015

WTF!? That's the change? Crazy.

@latkin
Copy link
Contributor

latkin commented Sep 8, 2015

lol, nice. Honestly seems like we are doing the right thing and C# should change... Ah well, LGTM.

@dungpa
Copy link
Contributor Author

dungpa commented Sep 8, 2015

I don't mind either way.

Visually, I think C# project system does the right thing. We shouldn't display a reference group as a folder; it's confusing.

@dungpa
Copy link
Contributor Author

dungpa commented Sep 8, 2015

BTW, it's fun to send two one-liner PRs in a row 😎

@latkin latkin added this to the F# 4.0 Update 1 milestone Sep 8, 2015
@latkin latkin closed this in e466cc0 Sep 9, 2015
@latkin latkin added the fixed label Sep 9, 2015
@dungpa dungpa deleted the reference-icon branch September 9, 2015 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
F# 4.0 Update 1
Development

Successfully merging this pull request may close these issues.
4 participants
@dungpa @forki @latkin @msftclas