Fix for 82 - Scope of types for named values in attributes improperly set #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade toolset to 14 and minimumvsversion to 14 to eliminate project upgrade. update oss version number for vs components to 14.0.0.9055 (changeset 1376881)
commit edc4d9bf4a3a6ac017ccf85c1e765374cc63b529 Author: latkin <[email protected]> Date: Mon Dec 1 13:32:55 2014 -0800 Updating surface area tests commit 9380ad5e64cfead4af96558a3bbd9fa121d10860 Author: latkin <[email protected]> Date: Mon Dec 1 11:27:14 2014 -0800 Fixups to correct build issues commit b280e160d717966e0b3128e0e608988ec31e0af3 Merge: 48f3fd6 7deeeca Author: latkin <[email protected]> Date: Mon Dec 1 10:29:45 2014 -0800 Merge branch 'feature1' of https://git01.codeplex.com/forks/dsyme/cleanup into nonullprovtypes commit 7deeeca8ef04d2d776e38f33721ef24f3197255c Author: Don Syme <[email protected]> Date: Tue Jun 24 19:53:03 2014 +0100 Let provided types be non-nullable
commit 7f0ad8f0b87b9bf9643d183c07a9543dcc3b89ec Author: latkin <[email protected]> Date: Mon Dec 1 12:25:20 2014 -0800 Updating TP test error baselines commit 97dd94747ac37d83f262702916e317167945a6a2 Merge: 9380ad5 765da89 Author: latkin <[email protected]> Date: Mon Dec 1 11:48:52 2014 -0800 Merge branch 'GetMethodsFix' of https://git01.codeplex.com/forks/dsyme/cleanup into TPFeedback Conflicts: src/fsharp/est.fs commit 765da896ffde21b9d1fc5bafb94e228ac292ace4 Author: Don Syme <[email protected]> Date: Fri Jun 27 15:12:46 2014 +0100 Do not error recover from failure in GetMethods in type provider
Conflicts: vsintegration/src/vs/FsPkgs/FSharp.Project/Common.Source.CSharp/Project/IDEBuildLogger.cs
…s functions" (changeset 1384847)
commit f864ece1fbe57b62413a8a020c08bffd21b271c1 Merge: 816e96e 66074d1 Author: latkin <[email protected]> Date: Thu Dec 11 15:45:57 2014 -0800 Merge branch 'WebClient-Async-Extensions' of https://git01.codeplex.com/forks/mexx24/visualfsharp into async commit 66074d1c16e786d25f88ab9525bd5bce9a08180a Author: Max Malook <[email protected]> Date: Thu Dec 4 11:57:44 2014 +0100 minor adjustments from code review commit b6d7917b3b97d177e0040f920d2386dfaaf9e6f4 Author: Max Malook <[email protected]> Date: Tue Oct 28 23:25:37 2014 +0100 add tests for AsyncDownloadData and AsyncDownloadFile methods commit 0dfdaa90cbcbc82e59bed59b91fbe1089a8c8fc5 Author: Max Malook <[email protected]> Date: Tue Oct 28 23:18:07 2014 +0100 introduce help method to remove code duplication commit 715061351cacbba833ac131912c4bb5e8540d7a9 Author: Max Malook <[email protected]> Date: Tue Oct 28 22:55:14 2014 +0100 add new methods to surface area commit 185342059e99b66f4814f6f7694f178d90a4f000 Author: Max Malook <[email protected]> Date: Sun Oct 12 11:53:57 2014 +0200 add extension methods AsyncDownloadData and AsyncDownloadFile
commit dab1082f5cd233a1525b443286fdbefd036da332 Author: latkin <[email protected]> Date: Thu Dec 11 17:04:09 2014 -0800 Escaping XML doc comment commit 3dda1099e6884acb63b3c2de7b4b9dce2a9d1696 Author: latkin <[email protected]> Date: Thu Dec 11 16:08:28 2014 -0800 Use built-in <|| operator commit db210d02e92c8ecc65086c457e11fc4d5de3ee34 Author: Patrick McDonald <[email protected]> Date: Wed Dec 10 11:57:38 2014 +0000 Refactor Seq.foldBack2 to use an uncurry function commit 83f56ce9881616da0b1517a9ae1b21288dcb1a84 Author: Patrick McDonald <[email protected]> Date: Tue Dec 9 20:37:43 2014 +0000 Change Seq.foldBack2 to use zip commit a8f3da0500bc57bdd0772c6026615373313a433f Author: Patrick McDonald <[email protected]> Date: Tue Nov 25 22:17:14 2014 +0000 Implement Seq.foldBack2
…sharp/fsharp commit c329c8b003bb56ba92011823e0be491bfe05870b Author: latkin <[email protected]> Date: Fri Dec 12 15:11:44 2014 -0800 Patching project system and tests to avoid using removed APIs commit f5c50b54e8b292f0de676951ae291da9176c6308 Author: Don Syme <[email protected]> Date: Mon Dec 1 14:32:36 2014 +0000 cleanup to align Visual F# Tools codebase textually with github.com/fsharp/fsharp
…Option.ofNullable commit 49a1d5f2abc1fbfaab6ea583d632777a62a766af Author: latkin <[email protected]> Date: Fri Dec 12 14:38:42 2014 -0800 Moving Option tests to proper file commit de9563b2bdc1b012b1cb8fc367f9440af06b6503 Author: latkin <[email protected]> Date: Fri Dec 12 14:31:34 2014 -0800 Updating surface area tests commit d90c61fa672149f717ce94125de7cfd725d2f9c1 Author: latkin <[email protected]> Date: Fri Dec 12 14:05:33 2014 -0800 Fixing doc comment commit 55bf33dbdd2742a5b3f27a242d2e4a60cfc6af68 Author: Don Syme <[email protected]> Date: Mon Nov 10 17:20:26 2014 +0000 add tryUnbox, isNull, Option.toObj, Option.ofObj, Option.toNullable, Option.ofNullable
… localization. updating the assemblyinfo files to use the single line comment syntax which it does apparently recognize. (changeset 1386388)
commit 45aed39c90ac5799c92ab73be3a558074caec37b Author: latkin <[email protected]> Date: Mon Dec 15 12:12:39 2014 -0800 Updating portable surface area test commit 64d3c0d84ae220569034bc19b5ea1b8b4f541516 Merge: 47aff4d 55b7aba Author: latkin <[email protected]> Date: Mon Dec 15 12:06:02 2014 -0800 Merge branch 'fsharp4' of https://git01.codeplex.com/forks/veritax/fsharp into decimal commit 55b7aba7996424418b68c9e5eede03afb41cc697 Author: Pierre IRRMANN <[email protected]> Date: Fri Nov 7 13:38:40 2014 +0100 Not using the SpecificCall pattern anymore commit 30d609727d1f0d1a9b70fa7ad5825b07f46b1633 Author: Pierre IRRMANN <[email protected]> Date: Thu Oct 23 06:41:22 2014 +0200 New test to prove the previously incorrect implementation, and fix commit 46cdf51905c1fbab4a26726cde19662ab66611be Author: Pierre IRRMANN <[email protected]> Date: Fri Oct 17 22:29:11 2014 +0200 Add an active pattern to match constant decimal in quotations
Conflicts: .gitignore tests/BuildTestTools.cmd vsintegration/src/vs/FsPkgs/FSharp.LanguageService/FSharp.LanguageService.Base/Properties/AssemblyInfo.cs
commit 3d64e6c4a6f9b9760e7e77e3031dff7d437169f6 Author: latkin <[email protected]> Date: Tue Dec 16 14:07:12 2014 -0800 Adding conditional compilation where required commit 8a5a33c99fcc82718adcd78146b59fe8f93321c9 Author: latkin <[email protected]> Date: Tue Dec 16 13:29:48 2014 -0800 Updating surface area tests commit 6c6925633d5c95bb0d34e16377651f6d62913ee1 Author: latkin <[email protected]> Date: Tue Dec 16 12:00:45 2014 -0800 Small test changes commit 3b4f1355ca0b5a022e18811a84d1fc6cda04b96e Author: latkin <[email protected]> Date: Tue Dec 16 11:59:03 2014 -0800 Fix doc comment commit 321c1abfe00bea20316daccc41bd33a873b50fe5 Merge: ecfa21c 979c99d Author: latkin <[email protected]> Date: Tue Dec 16 11:03:26 2014 -0800 Merge branch 'non-structural-eq-compare' of https://git01.codeplex.com/forks/dsyme/cleanup into comparison commit 979c99d6605a7b5b7540d94d0446d734728743c6 Author: Don Syme <[email protected]> Date: Tue Dec 2 18:20:07 2014 +0000 fix string comparison and add tests for decimal commit dc46cc5c9b2871711c22c9f364604361d8a14fef Author: Don Syme <[email protected]> Date: Tue Nov 11 12:33:49 2014 +0000 Add HashIdentity.NonStructural and ComparisonIdentity.NonStructural commit 5d84b340bd94579388a5394c8138e1cb99433cbc Author: Don Syme <[email protected]> Date: Tue Nov 11 11:38:03 2014 +0000 rename to NonStructuralComparison commit 768dfb521bf7bd25135e8e1a4603a15b86360903 Author: Don Syme <[email protected]> Date: Tue Nov 11 11:35:20 2014 +0000 rename to NonStructuralOperators commit 9f919071cd22d8ec994cfad6d7eb0cb209d6e164 Author: Don Syme <[email protected]> Date: Tue Nov 11 11:29:21 2014 +0000 add StaticCOmparisonOperators to LeafExpressionConvert for symmetry commit 9c59edcc43275a7060547df012e97b52c7d08e89 Author: Don Syme <[email protected]> Date: Tue Nov 11 11:09:26 2014 +0000 add testing and small fixes for StaticComparisonOperators commit 982da7b725a3cd8c25591f40e9a0e3d36d26bc00 Author: Don Syme <[email protected]> Date: Mon Nov 10 21:27:29 2014 +0000 fast structural comparison operators
…sion (changeset 1389609)
…nguage deployments. Issue is due to project new dialog handling template assets incorrectly. Workaround is to check in an additional extension.manifest for each vsix with assets specified such that the new project dialog displays them correctly. (changeset 1390834)
…o, Web Developer and Windows Desktop skus to 4.0.0 Note: there is a source.extension.manifest and an extension.manifest for each SKU with almost the same information as a workaround for VS Bug: 1097783 --- Localized VSIX templates with the same display name in each Locale render 8 times in the project wizard (changeset 1391800)
commit fd77e404911ea3948d8d6b59c9a53522eba2cef4 Author: latkin <[email protected]> Date: Wed Jan 7 17:15:14 2015 -0800 Further overflow/parsing fixes: check denominators, convert to bigint before negation commit 09e892b3eda586775767cef1866c994ace07d217 Author: andrewjkennedy <[email protected]> Date: Wed Jan 7 11:40:53 2015 +0000 Make parsing of -2147483648 in rational exponents an error commit 050b8b67c30c6857353d70449955c9872939b42a Author: latkin <[email protected]> Date: Tue Jan 6 14:48:11 2015 -0800 Remove unused error message commit 75b99d8561ff9aee087dc856cde106d6b4053622 Author: latkin <[email protected]> Date: Tue Jan 6 14:35:07 2015 -0800 Deleting obsolete tests commit ac97bcb9eb1079381c50071b5e3d95e21f21a12c Merge: f11c636 1877dff Author: latkin <[email protected]> Date: Mon Jan 5 15:58:51 2015 -0800 Merge branch 'unitsexprat' of https://git01.codeplex.com/forks/andrewjkennedy/fsharpcontrib into rationalexp Conflicts: src/fsharp/FSComp.txt commit 1877dff5235e538b6b406a17478ce9b81bad735b Author: andrewjkennedy <[email protected]> Date: Tue Dec 30 12:08:50 2014 +0000 Tests commit f7255be543782ae2aa5ed570c731eeb74d2205a1 Author: andrewjkennedy <[email protected]> Date: Mon Dec 29 15:37:59 2014 +0000 Added ref to System.Numerics commit 47180d60e4607233efe8a52be3f241c478793684 Author: andrewjkennedy <[email protected]> Date: Mon Dec 29 15:18:48 2014 +0000 Parsing of rational exponents is broken commit b5ce68705045ed9944183f8238c478f7db575aa5 Author: andrewjkennedy <[email protected]> Date: Mon Dec 29 13:47:26 2014 +0000 Revert "Overflow exception catching" This reverts commit 9259f5374d0d4f20f0fb5fb4ef43e0eba71027ae. commit 11e1ed21ccf05a0552c97d635c3b91e6e6397691 Author: andrewjkennedy <[email protected]> Date: Mon Dec 29 13:30:21 2014 +0000 Use BigIntegers for rationals commit 9259f5374d0d4f20f0fb5fb4ef43e0eba71027ae Author: andrewjkennedy <[email protected]> Date: Mon Dec 29 13:29:23 2014 +0000 Overflow exception catching commit 3b835e9b20e580b01bac7e81ea53cfaa36ac06c5 Author: andrewjkennedy <[email protected]> Date: Mon Nov 3 17:38:57 2014 +0000 Error message for non-parenthesized units commit 3160dbbac9e9e2799eb3fe13239525fa8ce8c568 Author: andrewjkennedy <[email protected]> Date: Mon Nov 3 16:18:31 2014 +0000 Improved error when parentheses are omitted from exponent commit f24e688d7794263f7dabb40f4ac9a498e82d517d Author: andrewjkennedy <[email protected]> Date: Mon Nov 3 13:24:59 2014 +0000 Negative test for rational exponent parsing commit 1e55326403626df25776226501bc8fedfc089adb Author: andrewjkennedy <[email protected]> Date: Mon Nov 3 11:21:05 2014 +0000 Zero denominator test commit f50f36f8603420298316ce966eb2e156e4052839 Author: andrewjkennedy <[email protected]> Date: Mon Nov 3 11:07:47 2014 +0000 Small improvements as suggested by Don commit 71fe676f97bf06dbf165defb0b1e10a250266126 Author: andrewjkennedy <[email protected]> Date: Mon Nov 3 11:07:02 2014 +0000 Some positive tests for rational exponents commit 0ac8fdc68ba807920c22b212be549751aa141548 Author: andrewjkennedy <[email protected]> Date: Thu Oct 30 13:44:44 2014 +0000 Fix bug on too many measure variables e.g. let f(x:float<'a 'b>) = x;; commit 2a227d0f4463d117f3022b34a18733e3b98d8594 Author: andrewjkennedy <[email protected]> Date: Thu Oct 30 10:58:49 2014 +0000 Check for 0 denominator commit 67acf8465ea5bfcb8766f7045ba5b47bf1a51fc5 Author: andrewjkennedy <[email protected]> Date: Thu Oct 30 10:41:05 2014 +0000 Couple of non-integer exponent tests commit 89881e2a94cf0e220051d68393d5e184ddc4634e Author: andrewjkennedy <[email protected]> Date: Thu Oct 30 10:16:18 2014 +0000 u_rational should be outside #ifdef commit 8461d5ee8632e15555680bc41cfea241f5ad7e5d Author: andrewjkennedy <[email protected]> Date: Wed Oct 29 11:05:14 2014 +0000 Updated comments commit c9da07d8f06311e2e62958e675f8082329651bf1 Author: andrewjkennedy <[email protected]> Date: Wed Oct 29 10:40:09 2014 +0000 Parentheses Revert LessGeneric test commit b6090279f81f6583d5a2bec18eeaebb308506148 Author: andrewjkennedy <[email protected]> Date: Tue Oct 28 15:42:18 2014 +0000 Negative test baseline - can now take sqrt of m! commit a69bfc41a0184784bee44c7a08f3206525b1ce81 Author: andrewjkennedy <[email protected]> Date: Tue Oct 28 14:58:50 2014 +0000 Simplification to simplification: compute reduced row echelon form then normalize exponents Syntax of negative rationals: permit either u^-(2/3) or u^(-2/3) commit 4a6143daaf38909d5b75e34d5fd4b036f4b862cc Author: andrewjkennedy <[email protected]> Date: Tue Oct 28 11:21:17 2014 +0000 More efficient representation of measures. Separate rational implementation. Better simplified form. commit 323d627288948359795797060216d8fe7d4676cf Author: andrewjkennedy <[email protected]> Date: Fri Oct 17 13:46:54 2014 +0100 Normalization of unit variable exponents in type schemes Insist on parentheses around rational constants - otherwise how do we parse float<kg^2/s> Still an issue with warnings wrt "too generic" commit 547444819d02f7df2f49b69c5ef32b039d58859b Author: andrewjkennedy <[email protected]> Date: Thu Oct 16 14:53:43 2014 +0100 Comment out measure unification algorithm and replace with one that makes use of rational exponents. Simpolification of type schemes will currently fail if any unit variables have non-integer exponent. commit 82b5fe40c907aae75036982dc7a4b168410e66e1 Author: andrewjkennedy <[email protected]> Date: Thu Oct 16 14:33:58 2014 +0100 TAST support for rational exponents; pretty-printing; pickling Solver currently projects out integers, fails on non-integers commit d558956a1476d79b6aaa52e6ccf6d1f2f5372dac Author: andrewjkennedy <[email protected]> Date: Thu Oct 16 11:52:49 2014 +0100 Implement syntax for rational exponents in units-of-measure Flag syntax error in type-checker if rational exponent encountered, for now
commit 6aff88a6c396711ccc980a57eb6f8de5d8021b11 Author: latkin <[email protected]> Date: Wed Jan 7 12:40:34 2015 -0800 Make sure to include default win32 manifest in .res file commit f5795ad24f6f43661c5e57020ba98aa4b983de0d Author: latkin <[email protected]> Date: Tue Jan 6 16:56:40 2015 -0800 Update fsianycpu with new icon commit 0ee3f33717c498ea3630b59e1c4902546c0526bd Author: latkin <[email protected]> Date: Tue Jan 6 16:56:23 2015 -0800 Update .res with new icon and add .rc file needed to create the .res commit 4f84e44b6f6cbd51cd863d6d9f32de79e60f4644 Author: latkin <[email protected]> Date: Tue Jan 6 16:27:34 2015 -0800 Changing icon to approved F# script icon used in VS commit 985fbdd5b202cf635ce32e04b438bc5972300ca7 Merge: f11c636 4a81a68 Author: latkin <[email protected]> Date: Tue Jan 6 16:07:15 2015 -0800 Merge branch 'master' of https://git01.codeplex.com/forks/brettv/visualfsharp into icon commit 4a81a680de761dc4ed7036bd993d6f80b9282667 Author: brettv <[email protected]> Date: Thu Jul 24 17:36:02 2014 -0700 add icon for fsi.exe
commit 4273c5af3e9d5ff60e9eca2d60c92c06c87ebdeb Merge: df8b476 d301929 Author: latkin <[email protected]> Date: Thu Jan 8 13:07:38 2015 -0800 Merge branch 'msft-optional' of https://git01.codeplex.com/forks/dsyme/cleanup into msftnamespace commit d301929def6926050c8b6e33dd2f621398162784 Author: Don Syme <[email protected]> Date: Tue Dec 2 15:10:33 2014 +0000 add more tests commit 5e2731b91bd6bc67c1d0252a4de9aade2d2e2809 Author: Don Syme <[email protected]> Date: Tue Dec 2 15:07:43 2014 +0000 update code comment commit 72c3bf1facd8c0684be838396b7d627e61959bc5 Author: Don Syme <[email protected]> Date: Tue Sep 16 16:18:51 2014 +0100 Make Microsoft optional in namepsace paths from FSharp.Core
Closes dotnet#17 commit 3d639ab68e247b52bbbbcc83d48b908e7db447af Author: latkin <[email protected]> Date: Thu Jan 15 13:43:40 2015 -0800 Cleaning up tests configs commit cbf4d76 Author: Steffen Forkmann <[email protected]> Date: Thu Jan 15 16:38:35 2015 +0100 Fix calls in #if EXTENSIONTYPING commit fd548e3 Author: Steffen Forkmann <[email protected]> Date: Thu Jan 15 16:21:08 2015 +0100 Reorder build order in proto-Compiler commit 8968e4f Author: xepaul <[email protected]> Date: Tue Nov 18 23:59:43 2014 +0000 Added Tests commit 3fd4931 Author: xepaul <[email protected]> Date: Thu Nov 13 23:27:27 2014 +0000 type argument bug fix commit 848cacf Author: xepaul <[email protected]> Date: Sun Sep 7 15:36:49 2014 +0100 Changes following PR comments :- match styling change. added open module to remove fully qualified path removed unnecessary comment "//need to hide" added during prototyping commit 0b2381f Author: xepaul <[email protected]> Date: Tue Jul 22 01:38:18 2014 +0100 Experiment to support assigning values to extension properties at initialization
Merge pull request dotnet#16 from dsyme/nativeptr-prep
This was added a while back because we had the opposite problem: items were mysteriously appearing directly under the root. See http://visualfsharp.codeplex.com/workitem/118 At some point another fix must have restored the expected 'Visual F# Items' node. Thus we now need to revert the original fix. fixes dotnet#282
partially addresses dotnet#106 closes dotnet#477 commit 5505b71 Author: Don Syme <[email protected]> Date: Sun May 31 16:48:05 2015 +1000 fix tests for invalidation handlers commit 0871018 Author: Don Syme <[email protected]> Date: Sun May 31 16:35:47 2015 +1000 add diagnostic counters to signature commit e8afa9c Author: Don Syme <[email protected]> Date: Sun May 31 15:07:35 2015 +1000 Fix memory leak: not disposing even subscriptions to invalidation events
…GetActiveConfigurationAndPlatform - Use `IVsSolutionBuildManager5.FindActiveProjectCfgName` instead of `IVsSolutionBuildManager2.FindActiveProjectCfg` in `TryGetActiveConfigurationAndPlatform`, as it is not sensitive to sync context - Give proper consideration to the VSUTDCF options flags passed to QueryStartUpToDateCheck fixes dotnet#471 closes dotnet#479
- Older NUnit used internally compares collections differently - Has trouble with nested collections - Enforces that empty collections have the same type (newer NUnit is lax about this) - Add `NoMT` test tag to various new tests that don't support mixed .NET version testing (i.e. .NET 2/4 multitargeting) - Make sure all IDE bits build with correct versions of VS SDK dependencies - IDE unit tests were all failing with latest VS RC installed - Various small tweaks to account for versioning and file paths used by VS closes dotnet#482 commit 539225b Author: latkin <[email protected]> Date: Tue Jun 2 12:35:30 2015 -0700 Add missing project file commit f8d9fe8 Author: latkin <[email protected]> Date: Tue Jun 2 07:27:43 2015 -0700 Another core unit tests fix commit f6d830b Author: latkin <[email protected]> Date: Thu May 28 13:33:08 2015 -0700 Use correct, consistent versions of VS binaries commit 827044c Author: VFSharpTeam <[email protected]> Date: Thu May 28 10:01:23 2015 -0700 More test fixes commit fe8661f Author: latkin <[email protected]> Date: Wed May 27 16:36:37 2015 -0700 First batch
On package load, check if any of the custom F# settings are somehow missing from the settings store. Explicitly set them to their desired defaults if they are indeed missing. Added to the language service package since this is guaranteed to load any time the project system package is loaded, but the converse is not true (e.g. open loose F# script file without opening a solution). fixes dotnet#199 closes dotnet#491 commit da9f29a Author: latkin <[email protected]> Date: Wed Jun 10 09:33:28 2015 -0700 Don't create unused binding in VS 12.0 commit 92c8919 Author: latkin <[email protected]> Date: Tue Jun 9 18:55:54 2015 -0700 APIs used are new for 14.0, omit them for 12.0 builds commit a662e18 Author: latkin <[email protected]> Date: Tue Jun 9 17:28:22 2015 -0700 Code review feedback, and add clickable URLs setting commit b6697a7 Author: latkin <[email protected]> Date: Mon Jun 8 18:13:35 2015 -0700 Explicitly set custom F# VS settings if they are missing
fixes dotnet#486 closes dotnet#497 commit a24d85b Author: latkin <[email protected]> Date: Fri Jun 12 15:24:41 2015 -0700 Revert to all old code commit 9cf81de Author: latkin <[email protected]> Date: Thu Jun 11 11:52:11 2015 -0700 Add extra test case for fixed non-inline APIs commit f552478 Author: latkin <[email protected]> Date: Thu Jun 11 10:52:18 2015 -0700 Use lazy-evaluated resource string for all non-inline APIs commit 76871e6 Author: latkin <[email protected]> Date: Mon Jun 8 19:54:19 2015 -0700 Add tests for multitargeting scenarios commit 3d6cfcf Author: latkin <[email protected]> Date: Thu Jun 11 10:01:57 2015 -0700 Roll back 52a7252
This was causing internal execution to fail when directory names contained various special character.
An example case is Array.chunkBySize 3 [|1..4|], the code calculates the number of chunks to be 2, and then does not copy the final (partial) chunk as 4 mod 2 is 0. Similarly for Array.chunkBySize 5 [|1..12|], number of chunks is 3 and 12 % 3 = 0 Changing check to len % chunkSize fixes this. Fixes dotnet#501 Closes dotnet#503
…assembly refs ConvILTypeRefUnadjusted properly handles the case where the reference is statically linked. ConvILTypeRef does not. These two used to be a single API. They were split in 640db00 and it was a simple oversight that the wrong one was wired up here. fixes dotnet#492 closes dotnet#510
This is a pass of cleanup that renames some files to get rid of most cryptic abbreviations like "csolve", and does some other code cleanup and documentation too.
- commenting in "detuple.fs"
- removing ExtensibleDumper.fs which is an old adhoc debug mechanism barely used in the codebase
- removing some dead code in fsc.fs (some code was already duplicated in fscmain.fs too!)
- renaming check.{fs,fsi} --> PostInferenceChecks.{fs,fsi}
- renaming tc.{fs,fsi} --> TypeChecker.{fs,fsi}
- renaming opt.{fs,fsi} --> Optimizer.{fs,fsi}
- renaming est.{fs,fsi} --> ExtensionTyping.{fs,fsi}
- renaming build.{fs,fsi} --> CompileOps.{fs,fsi}
- renaming fscopts.{fs,fsi} --> CompileOptions.{fs,fsi}
- moving the option parser to CompileOptions.fs (where it belongs!)
- marking some record types as RequireQualifiedAccess (to give better errors when editing the compiler)
- removed a whole bunch of semicolons
- removed some old debugging output (verboseStamps etc.)
closes dotnet#357
commit 5e69236
Author: Don Syme <[email protected]>
Date: Mon Aug 3 14:09:33 2015 +0100
restore code that should not have been removed
commit 7e8eda59c2929b2cfc55f24a7c96cec28994e892
Author: latkin <[email protected]>
Date: Fri Jul 31 18:15:49 2015 -0700
Fix expected text in Watson test
commit 248a14c
Merge: 4767d5b dd8252e
Author: Don Syme <[email protected]>
Date: Thu Jul 9 16:42:28 2015 +0100
integrate & merge with latest HEAD
commit 4767d5b
Author: Don Syme <[email protected]>
Date: Fri Apr 10 17:25:23 2015 +0200
update to force appveyor
commit 0600f3e
Author: Don Syme <[email protected]>
Date: Fri Apr 10 16:52:21 2015 +0200
update to force appveyor
commit 02c6c6c
Author: Don Syme <[email protected]>
Date: Fri Apr 10 16:38:12 2015 +0200
update to fix build
commit 877a1d2
Author: Don Syme <[email protected]>
Date: Fri Apr 10 16:30:50 2015 +0200
update to fix build
commit dd886be
Author: Don Syme <[email protected]>
Date: Fri Apr 10 14:03:02 2015 +0200
update to fix build
commit 4f73a2b
Author: Don Syme <[email protected]>
Date: Fri Apr 10 13:46:02 2015 +0200
update proto (4)
commit 5430936
Author: Don Syme <[email protected]>
Date: Fri Apr 10 13:44:10 2015 +0200
update to fix build
commit 93d94c9
Author: Don Syme <[email protected]>
Date: Fri Apr 10 13:35:15 2015 +0200
update proto ()
commit 77fa7ac
Author: Don Syme <[email protected]>
Date: Fri Apr 10 13:31:35 2015 +0200
update proto and renamings
commit 8797a81
Author: Don Syme <[email protected]>
Date: Fri Apr 10 13:05:09 2015 +0200
integrate cleanup with fsharp4 (2)
commit 31777c7
Merge: c6ffdb6 bb09bb3
Author: Don Syme <[email protected]>
Date: Fri Apr 10 12:43:00 2015 +0200
integrate cleanup with fsharp4
commit bb09bb3
Author: Don Syme <[email protected]>
Date: Mon Dec 1 09:53:04 2014 +0000
remove more semicolons in ilwrite.fs
commit a3ca155
Author: Don Syme <[email protected]>
Date: Sun Nov 30 20:23:14 2014 +0000
code cleanup inn ilwrite.fs and il.fs
commit f2e301e
Author: Don Syme <[email protected]>
Date: Sun Nov 30 15:54:21 2014 +0000
cleanup and rename build.fs and fscopts.fs
commit 20cb9b0
Author: Don Syme <[email protected]>
Date: Sun Nov 30 00:19:12 2014 +0000
make some more functions into members in tast.fs
commit ddadb30
Author: Don Syme <[email protected]>
Date: Sat Nov 29 23:31:17 2014 +0000
additional cleanup in tast.fs (2)
commit 662d87c
Author: Don Syme <[email protected]>
Date: Sat Nov 29 23:25:14 2014 +0000
additional cleanup and comments in tast.fs
commit a27f527
Merge: 79b8293 4f94347
Author: Don Syme <[email protected]>
Date: Sat Nov 29 20:37:10 2014 +0000
Merge branch 'master' of https://git01.codeplex.com/visualfsharp into master-cleanup-1
commit 79b8293
Author: Don Syme <[email protected]>
Date: Sat Nov 29 20:35:26 2014 +0000
code cleanup and file rename
remove all of the `/*internal, but public for FSharp.Project.dll*/` comments, and other small cleanups closes dotnet#349 commit 4a8abefeddc58809f7429434649e2f5b02f67ff7 Author: enricosada <[email protected]> Date: Thu Apr 9 16:44:03 2015 +0200 fix naming commit 2767f161028cfc78078eb7ac197f36bfdaed6e2e Author: enricosada <[email protected]> Date: Thu Apr 9 16:39:48 2015 +0200 unused comment and using commit 784d73e80827ccb79485b07c481043842a1511a1 Author: enricosada <[email protected]> Date: Thu Apr 9 16:32:46 2015 +0200 cleanup commit 3d9dd20bda3f27b35ab38c342f347b3d48fdd0b7 Author: enricosada <[email protected]> Date: Wed Apr 8 17:18:46 2015 +0200 fix xml docs commit c737d7c82621eef223cc894be9c6fc415ddbf67e Author: enricosada <[email protected]> Date: Wed Apr 8 17:16:19 2015 +0200 remove commented out code commit 9ddf4c15b2fa9ea1d82dffa37ae632062b24c33d Author: enricosada <[email protected]> Date: Wed Apr 8 17:11:35 2015 +0200 style fix commit 24cdafd72721d2f81711d15d7f412b1f8810d719 Author: enricosada <[email protected]> Date: Wed Apr 8 17:10:44 2015 +0200 possible null ref, check parent before parent.onChildAdded commit 3c74d24fd7e9ec78ae2cfddcd9d993d74e080742 Author: enricosada <[email protected]> Date: Wed Apr 8 17:08:11 2015 +0200 remove unused commit 54bdb0530c64a959c345cfffa5566f4ddba753d8 Author: enricosada <[email protected]> Date: Wed Apr 8 17:00:50 2015 +0200 remove comment /*[access-modifier], but [access-modifier] for FSharp.Project.dll*/
- remove `#region`s - removed include of not existing doc in comments (noise) - remove redundant comments (`/// this is a constructor`) - remove commented code - remove an empty file closes dotnet#358 commit c34491923f46ecbf2984d58ba3bf4e3391205a6e Author: enricosada <[email protected]> Date: Thu Apr 16 15:03:14 2015 +0200 removed comment commit 6daf02cf3d65c342f4aff8d4bebc1cc2fa0a3506 Author: enricosada <[email protected]> Date: Fri Apr 10 14:56:39 2015 +0200 remove empty file commit 0e736d994beecbec9263808edb04f5170e99fbe0 Author: enricosada <[email protected]> Date: Thu Apr 9 23:10:38 2015 +0200 remove commented code commit b4422b9eef39cccb10a60a0216f313915b10a5eb Author: enricosada <[email protected]> Date: Fri Apr 10 11:26:29 2015 +0200 removed redundant comments commit f8a981dc1f88db773be00bfff7aa993424eab985 Author: enricosada <[email protected]> Date: Thu Apr 9 23:19:34 2015 +0200 remove include external doc in comments commit f59c84cd386ed89e5b99f950e145d33f02913e78 Author: enricosada <[email protected]> Date: Fri Apr 10 14:56:00 2015 +0200 remove #region
Deletes code conditional on unused defines - SINGLE_FILE_GENERATOR - NOT_YET_NEEDED - BETA2 - IMPLEMENT_IVSPERSISTHIERARCHYITEM2 - IVsOutliningCapableLanguage - CUT - DISABLED - OLDCODE - Suggestion4299 - UNUSED_DEPENDENT_FILES - UNUSED_NESTED_PROJECTS - NEVER - false - UNUSED closes dotnet#353 commit 2839aab40f4e3ab434f0738d5c8e3691d7c2c5df Author: latkin <[email protected]> Date: Mon Aug 3 17:22:20 2015 -0700 Fix merge conflict commit fc4602bf8b60204d85e707db1438f78cc082cb3d Author: enricosada <[email protected]> Date: Thu Apr 9 18:15:19 2015 +0200 remove SINGLE_FILE_GENERATOR commit 2dc0802e76006c6f5dcceae3360325eba01aea6c Author: enricosada <[email protected]> Date: Thu Apr 9 18:08:21 2015 +0200 remove NOT_YET_NEEDED commit df49b75211747dcd4e0ff887ef4473a280bf4a59 Author: enricosada <[email protected]> Date: Thu Apr 9 18:05:56 2015 +0200 remove BETA2 commit 70858f0689b29638ebfb35e1c3b0aa149895b801 Author: enricosada <[email protected]> Date: Thu Apr 9 18:05:36 2015 +0200 remove IMPLEMENT_IVSPERSISTHIERARCHYITEM2 commit d5ec2047ed550db9396892bfbdea28b07bc46193 Author: enricosada <[email protected]> Date: Thu Apr 9 18:02:21 2015 +0200 remove IVsOutliningCapableLanguage commit 7f78d984171b4ed22da6339c6b799bbd44e743b3 Author: enricosada <[email protected]> Date: Thu Apr 9 17:55:24 2015 +0200 remove CUT commit d781a86012e497dd81fe811250d5efb481c80945 Author: enricosada <[email protected]> Date: Thu Apr 9 17:54:59 2015 +0200 remove DISABLED commit d19d387bd38a0b60e688fe6fa40a24d539d5853d Author: enricosada <[email protected]> Date: Thu Apr 9 17:50:06 2015 +0200 remove OLDCODE commit 1997a739aa040aa06428f2d225f7d8771b27f938 Author: enricosada <[email protected]> Date: Thu Apr 9 17:48:02 2015 +0200 remove Suggestion4299 commit 58cfe73fd9931dfb0276be146dc8d51c04c68c51 Author: enricosada <[email protected]> Date: Thu Apr 9 17:31:29 2015 +0200 remove UNUSED_DEPENDENT_FILES commit 790e49786bb74b1c7a3915ed4b4aaf6243543803 Author: enricosada <[email protected]> Date: Thu Apr 9 17:19:47 2015 +0200 remove UNUSED_NESTED_PROJECTS commit b738f464175e825dad7abdc55ad0e0e20a36545c Author: enricosada <[email protected]> Date: Thu Apr 9 17:01:08 2015 +0200 remove NEVER commit 1f9dea77c2618eeaadec25edced524d51c21b534 Author: enricosada <[email protected]> Date: Thu Apr 9 16:59:43 2015 +0200 remove false commit e43fe145b73c81329c1af18744517bef7deb9da4 Author: enricosada <[email protected]> Date: Thu Apr 9 16:57:27 2015 +0200 remove UNUSED
ReferenceResolution.fs/fsi has long been messy in a way that obscured what it does. This is some code cleanup (no change in functionality) to remove some of the obscurity. This came from reviewing the code with Robin Neatherway. closes http://visualfsharp.codeplex.com/SourceControl/network/forks/dsyme/cleanup/contribution/7671 commit dbd480e5f58418782bcc0f0dde54a5bc8bfe346f Author: Don Syme <[email protected]> Date: Mon Nov 10 16:21:12 2014 +0000 put net10 and net11 back commit ac83e77a8d6a9fe93dab5afa904761feec27be08 Author: Don Syme <[email protected]> Date: Mon Nov 10 16:05:52 2014 +0000 cleanup ReferenceResolution.fs
|
This has been idle for over 2 months, closing out. Please re-open when the fix is ready and tests are implemented, we'd be happy to include in an update release. |
|
This is a real bug that we shouldn't leave lying around. The fix is good AFAIK, we should either test manually and apply or add the automated testing. |
dsyme
changed the title
|
Ok if you think it's no longer in the "prelim" stage then we should take it. Are you planning to add tests, or should I do that myself when I merge it? |
|
I believe the fix to be good in principle, I just haven't tested it even by hand. I suppose we should add the bespoke test mentioned by @vladima above. I'd hoped there would be a test that didn't involve a type provider though. |
|
Closing to resubmit to OOB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary fix for #82. Testing involves the WSDL type provider so is a bit tricky. @vladima - do you have advice?