Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation view in VS fails to load #4937

Closed
cartermp opened this issue May 17, 2018 · 3 comments
Closed

Annotation view in VS fails to load #4937

cartermp opened this issue May 17, 2018 · 3 comments

Comments

@cartermp
Copy link
Contributor

  1. Open a file that is tracked by git
  2. Annotate (Blame)

image

@cartermp
Copy link
Contributor Author

In this line, heir is null: https://github.com/Microsoft/visualfsharp/blob/master/vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs#L662

And we don't exhaustively check for null here.

@cartermp
Copy link
Contributor Author

Not sure why it would start triggering in 15.7.

@cartermp
Copy link
Contributor Author

Aha. It could still be null in the past, but #4328 captures it into a binding that it then attempts to . into. This was not observable in 15.6 because we didn't ship the miscfiles work until 15.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant