Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libevent] Upgrade to version 2.1.10 #6969

Merged
merged 5 commits into from
Jun 25, 2019
Merged

[libevent] Upgrade to version 2.1.10 #6969

merged 5 commits into from
Jun 25, 2019

Conversation

LilyWangL
Copy link
Contributor

  1. Upgrade to version 2.1.10.
  2. Remove old patch due to source changes.
  3. Fix bin path.
  4. Fix build error on triplet arm:
   Creating library lib\event.lib and object lib\event.exp
evutil_rand.c.obj : error LNK2019: unresolved external symbol __imp_CryptAcquireContextA referenced in function arc4_seed_win32
evutil_rand.c.obj : error LNK2019: unresolved external symbol __imp_CryptGenRandom referenced in function arc4_seed_win32
evdns.c.obj : error LNK2019: unresolved external symbol __imp_RegCloseKey referenced in function load_nameservers_from_registry
evdns.c.obj : error LNK2019: unresolved external symbol __imp_RegOpenKeyExA referenced in function load_nameservers_from_registry
evdns.c.obj : error LNK2019: unresolved external symbol __imp_RegQueryValueExA referenced in function config_nameserver_from_reg_key
evdns.c.obj : error LNK2019: unresolved external symbol __imp_SHGetSpecialFolderPathA referenced in function evdns_get_default_hosts_filename
bin\event.dll : fatal error LNK1120: 6 unresolved externals

Related issue: #6922

@LilyWangL LilyWangL mentioned this pull request Jun 20, 2019
Closed
@ras0219-msft ras0219-msft added the info:internal This PR or Issue was filed by the vcpkg team. label Jun 20, 2019
@LilyWangL
Copy link
Contributor Author

Use libevent generated LibeventConfig.cmake by replacing find_package(Libevent CONFIG REQUIRED) instead with find_package (Libevent MODULE REQUIRED) in fizz/CMakeLists.txt:84.

@LilyWangL LilyWangL marked this pull request as ready for review June 25, 2019 05:43
@Rastaban Rastaban merged commit 7401e2f into microsoft:master Jun 25, 2019
pull bot pushed a commit to harrysummer/vcpkg that referenced this pull request Jun 25, 2019
@LilyWangL @pull
[libevent] Upgrade to version 2.1.10 (microsoft#6969)
5197a24
@skidman123
Copy link

congrats on #6969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Rastaban Rastaban

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LilyWangL @skidman123 @Rastaban @ras0219-msft