-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ixwebsocket] add new port #6835
[ixwebsocket] add new port #6835
Conversation
FYI There is CI on the github project for macOS + Linux + windows. I haven't explored all options ... currently mbedtls is required (and bundled) or SSL on Windows, and openssl is required on Linux (but not bundled) ; both of those dependencies could be expressed properly using vcpkg. zlib is also required and bundled with the source on Windows. Thanks for taking a look and making the missing package manager for C++ ! |
I don't really understand where to look for in Azure DevOps for my build error, if someone can help that would be great. |
The "summary" tab has what you're looking for @bsergean |
Thanks I found it. At this point my problem is that I am 'double installing some dependent header + libs' since I was 'including those files directly. I will fix that.
… On Jun 9, 2019, at 4:52 PM, Griffin Downs ***@***.***> wrote:
The "summary" tab has what you're looking for @bsergean <https://github.com/bsergean>
<https://user-images.githubusercontent.com/35574547/59165843-e4eecb00-8ad6-11e9-856b-982bb9fd75d0.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#6835?email_source=notifications&email_token=AC2O6UIBBWTVGTA6CJ4ONITPZWJUXA5CNFSM4HWOZEF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIUWUY#issuecomment-500255571>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC2O6UJNW3FVDUWDVP4XACDPZWJUXANCNFSM4HWOZEFQ>.
|
…stead of vendoring it by default
Looks like CI is happy now, likely thanks to that change -> machinezone/IXWebSocket@750a752 |
It is not ideal the way it is, as only some libraries are only needed on some platforms (namely the SSL libraries). It looks like curl uses the concept of vcpkg optional features which I should explore. |
I just found in the curl CONTROL file (something from debian btw ?) how to have per os deps:
I'll try to play with that so that only minimal deps are installed. |
That osx error looks weird. I might queue up another job.
|
Provided the CI complete I'd be happy to have this merged as is to get the ball rolling. I'll setup vcpkg on a Linux machine (I have access to those, mostly through containers), everything works well with features locally. Unfortunately I don't have access to a windows box but was thinking about using Azure to do so. If I get access to such a box I'll try to investigate why is it I cannot use features like curl. However I feel like this is a Azure DevOps problem, cf that same error that showed up, while everything was working fine with the same code, before I tried to setup features. Odd.
|
/azp run |
The osx agent looks stuck ... now I'm tempted to try to use the features thing again as it could have been a fluke with the CI system. |
This reverts commit 4666b18.
@bsergean we're currently having some trouble with the Mac CI system. It should be back in good condition relatively soon, so feel free to keep those changes in. Thanks for bearing with us! |
No worries ! And ironically it succeeded on Mac at that last run ! Now I'm back to a failure on Windows, which I should look into. Unfortunately the error message isn't accessible and is in a log file, which cannot be viewed easily from the web ui. It would be good to 'cat' that error file I would say when things fails on CI. One error briefly mention ninja. Is ninja not available on Windows ? (I don't think so)
|
Hey @grdowns I think I have finally found the proper magic in the CONTROL file and now CI is happy. Would it be acceptable to merge as is now ? |
@bsergean I've changed it so that its just a call to vcpkg_from_github instead. |
Perfect, looks cleaner that way. |
Thanks for the PR! |
Thanks guys ! |
https://github.com/machinezone/IXWebSocket
IXWebsocket is a lightweight (very few dependencies, notably no boost) client and server websocket library + http client library, with SSL and per message deflate support.