[libraw] Add include for select_library_configurations (#6715) #6742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloskot
reviewed
Jun 3, 2019
| @@ -32,6 +32,8 @@ | |||
| + ${PC_LIBRAW_R_LIBRARY_DIRS} | |||
| + ) | |||
| + | |||
| +INCLUDE(SelectLibraryConfigurations) | |||
There was a problem hiding this comment.
Shouldn't this line be placed before the line 21?
i.e. before select_library_configurations(LibRaw)
There was a problem hiding this comment.
Sorry, should be fixed now.
trylle
force-pushed
the
libraw_add_missing_select_library_configurations_include
branch
from
93af2d1 to
d2bbf25
Compare
|
Hi @trylle, thanks for your PR. Could you also bump the version in CONTROL file? |
mloskot
reviewed
Jun 6, 2019
ports/libraw/CONTROL
Outdated
| @@ -1,4 +1,4 @@ | |||
| Source: libraw | |||
| Version: 0.19.2 | |||
| Version: 0.19.2-1 | |||
There was a problem hiding this comment.
OK, I've rebased the PR onto master and bumped the version to 201903-1 to differentiate from #6759 already merged into master.
trylle
force-pushed
the
libraw_add_missing_select_library_configurations_include
branch
from
e71ef11 to
d66183d
Compare
|
Thanks. |
|
Nothing, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if this resolves your problem, @mloskot.