-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update shaderc #6689
update shaderc #6689
Conversation
ports/glslang/portfile.cmake
Outdated
@@ -20,7 +20,7 @@ vcpkg_configure_cmake( | |||
|
|||
vcpkg_install_cmake() | |||
|
|||
vcpkg_fixup_cmake_targets() | |||
#vcpkg_fixup_cmake_targets() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if glslang install/exports configs & targets this line should not be commented!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, problem was with the old cmake targets patch not being applied.
I can't access Vcpkg-PR-Eager... Looking vcpkg-Linux-PR, it seems this warning causes the build to failed:
Don't know how to get rid of that ? |
Hi @doomtr666, thanks for your PR. I see that spirv-tools failed on x64-Linux from the current CI system. |
Hi,
It seems it's this warning (analyzing step) that cause the build to fail:
CMake Warning:
Manually-specified variables were not used by the project:
VCPKG_PLATFORM_TOOLSET
But I don't know how to get rid of that ?
Christophe
Le lun. 3 juin 2019 à 11:10, NancyLi1013 <[email protected]> a
écrit :
… Hi @doomtr666 <https://github.com/doomtr666>, thanks for your PR. I see
that spirv-tools failed on x64-Linux from the current CI system.
failureLogs.zip
<https://github.com/microsoft/vcpkg/files/3246766/failureLogs.zip>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6689?email_source=notifications&email_token=ABXGT2WI5JRJDDHYO4LIWD3PYTNXPA5CNFSM4HREWUK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWYZE4I#issuecomment-498176625>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABXGT2R3CQ4LFMSA2MCHAZDPYTNXPANCNFSM4HREWUKQ>
.
|
I found this problem during install on Linux, a requires Python module is not installed in the CI machines.
|
Would installing python3-distutils via apt-get on the CI machines do the trick? If so we can take care of that and rerun the tests. |
I haven't had time to check locally, I'll test and let you know. |
Any news about the CI update ? |
I've commented out the distutils line in spirv-tools in a patch, which might fix the problem on the CI. The build seems to work, but I'm not sure if this will break anything else. So feel free to remove my changes. |
I've done some tests, all is ok for me. |
Thanks for the PR! |
New version supports NVidia Turing extensions (ray tracing). Tested on VS2019 Comunity.
Note that I was unable to activate SPVC options correctly (enables shader reflection and depends of spirv-cross), I had various link errors.