This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
#451 : Add logic to support more specifiers for import-name #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
monicbhanushali
commented
Oct 6, 2018
| moduleName = this.makeCamelCase(moduleName); | ||
| if (this.isImportNameValid(importedName, moduleName) === false) { | ||
| const message: string = `Misnamed import. Import should be named '${moduleName}' but found '${importedName}'`; | ||
| let expectedImportedName = moduleName.replace(/.*\//, ''); // chop off the path |
There was a problem hiding this comment.
I changed the variable name moduleName to expectedModuleName as it was confusing.
Also the primary reason for new variable was to make sure that we aren't changing the input we get which the code was doing earlier.
monicbhanushali
commented
Oct 6, 2018
| return Utils.exists(Object.keys(this.replacements), (replacementKey: string): boolean => { | ||
| if (new RegExp(replacementKey).test(moduleName)) { |
There was a problem hiding this comment.
I replaced this Regex check with exact string match because in scenarios like below, the regex would match for both the import-names
import abc from 'fs/my-package'
import pqr from 'super/my-package'
JoshuaKGoldberg
suggested changes
Oct 7, 2018
JoshuaKGoldberg
approved these changes
Oct 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #451
import-namevalidation logic to include more specifiers as replacement-keys