Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

use-named-parameter shouldn't be marked as TypeScript-only #673

Closed
JoshuaKGoldberg opened this issue Dec 13, 2018 · 0 comments · Fixed by #681
Closed

use-named-parameter shouldn't be marked as TypeScript-only #673

JoshuaKGoldberg opened this issue Dec 13, 2018 · 0 comments · Fixed by #681
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Good First Issue 🙌 Howdy, neighbor! Status: Accepting PRs Type: Bug
Milestone
6.1.0-beta

Comments

@JoshuaKGoldberg
Copy link

JoshuaKGoldberg commented Dec 13, 2018 •
edited
Loading

Bug Report

  • tslint-microsoft-contrib version: 6.0.0

typescriptOnly: true,

Not true - the rule can run on JS files too.

See the rule metadata in src/useNamedParameterRule.ts

Subset of #646.
@JoshuaKGoldberg JoshuaKGoldberg added Type: Bug Status: Accepting PRs Good First Issue 🙌 Howdy, neighbor! Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. labels Dec 13, 2018
@drexler drexler mentioned this issue Dec 17, 2018
Merged
@IllusionMH IllusionMH added this to the 6.1.0-beta milestone Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Good First Issue 🙌 Howdy, neighbor! Status: Accepting PRs Type: Bug
Projects
None yet
Milestone
6.1.0-beta
Development

Successfully merging a pull request may close this issue.

remove Typescript-only restriction of use-named-parameter rule drexler/tslint-microsoft-contrib
2 participants
@IllusionMH @JoshuaKGoldberg