This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

The use-isnan rule is still being distributed #379

Closed

ChrisMBarr opened this issue Jun 30, 2017 · 1 comment

Milestone

Contributor

ChrisMBarr commented Jun 30, 2017

As of ther 5.0.1 release removed this rule in #372, but upon looking in the node_modules folder, the file is still there.

The text was updated successfully, but these errors were encountered:

HamletDRC added a commit that referenced this issue


          #379 Removed useIsnanRule from distribution

0de1920

closes #379

HamletDRC added this to the 5.0.2 milestone

HamletDRC closed this as completed

Contributor Author

ChrisMBarr commented Jan 10, 2018

The actual rule has been removed, but when it comes time to actually release 5.0.2, be sure to delete thes references to the rule

https://github.com/Microsoft/tslint-microsoft-contrib/blob/master/tslint.json#L273
https://github.com/Microsoft/tslint-microsoft-contrib/blob/master/recommended_ruleset.js#L98
https://github.com/Microsoft/tslint-microsoft-contrib/blob/master/additional_rule_metadata.json#L580-L587
https://github.com/Microsoft/tslint-microsoft-contrib/blob/master/tslint-warnings.csv#L298

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.