Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

react-tsx-curly-spacing bug with comments #353

Closed
testerez opened this issue Mar 30, 2017 · 1 comment
Closed

react-tsx-curly-spacing bug with comments #353

testerez opened this issue Mar 30, 2017 · 1 comment
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Good First Issue 🙌 Howdy, neighbor! Status: Accepting PRs Type: Bug
Milestone

Comments

@testerez
Copy link

With setting: "react-tsx-curly-spacing": [true, "never", {"allowMultiline": true}],
I get an error for: <div>{/* comment */}</div>
Error: There should be no space before '}' (react-tsx-curly-spacing)

@JoshuaKGoldberg JoshuaKGoldberg added Type: Bug Status: Accepting PRs Good First Issue 🙌 Howdy, neighbor! Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. labels Jul 6, 2018
JoshuaKGoldberg pushed a commit that referenced this issue Oct 8, 2018
* Add single comment jsx expression test case

* Add node children count check to avoid empty code block validation
@JoshuaKGoldberg
Copy link

JoshuaKGoldberg commented Oct 8, 2018

#533 should fix this particular version of the bug. If there's still an issue with comments, that would be a separate and unfortunately more difficult issue.

@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Good First Issue 🙌 Howdy, neighbor! Status: Accepting PRs Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants