Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Port TSX curly spacing rule. #302

Closed
wants to merge 1 commit into from

Conversation

@msftclas
Copy link

Hi @lijunle, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Junle Li). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@HamletDRC HamletDRC added this to the 2.0.14 milestone Oct 24, 2016
@HamletDRC
Copy link
Member

hi @lijunle
Thanks for the rule and taking the time to submit this.

One note: eslint-plugin-react is an MIT licensed project. So if we copy and paste a regular expression from that project to ours then we need to declare the project in our copyright notice and give proper credit. I would prefer to have zero dependencies, so I will rewrite this regular expression.

Another note: the build is failing because the rule is not documented in readme.md and there is no metadata.

Lastly, I will add some unit tests.

Thanks for the submission! I will try to merge this today.

@HamletDRC HamletDRC closed this in 58e62a1 Oct 24, 2016
@HamletDRC
Copy link
Member

Alright, I added tests and actually fixed an edge case. it all looks good. Thanks!

@lijunle
Copy link
Member Author

lijunle commented Oct 24, 2016

Super thank you for handling this! You are awesome!

@HamletDRC
Copy link
Member

Well, thanks for the PR!

In the future, if you create a rule be sure to use:

grunt create-rule my-rule-name

Then it generates tests and documentation for you :)

@HamletDRC HamletDRC modified the milestone: 2.0.14 Oct 26, 2016
@lijunle lijunle deleted the tsx-curly-spacing branch October 29, 2016 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants