Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Export TestHelper in npm package #184

Closed
ipip2005 opened this issue Aug 4, 2016 · 7 comments
Closed

Export TestHelper in npm package #184

ipip2005 opened this issue Aug 4, 2016 · 7 comments
Milestone

Comments

@ipip2005
Copy link
Collaborator

ipip2005 commented Aug 4, 2016

This is not actually an issue.

The TestHelper.ts file under tests folder is really useful, can it be exported so we can use it in our project?

@HamletDRC
Copy link
Member

I can, but...

  • it depends on fs from node (so it does not work in the browser)
  • it assumes all files are utf-8 encoded (so you'd better have the correct encoding on your files)
  • it would mean exporting the d.ts file

Do you really want it exported?

@HamletDRC
Copy link
Member

Also, feel free to submit your rules here as a feature request!

@ipip2005
Copy link
Collaborator Author

ipip2005 commented Aug 7, 2016

Yes, it would be helpful, I would use this file to test my customized rules.
One problem is the rulesDirectroy and formatterDirectory is hard coded, I can only use it if I can specify this option.
And thanks for your offer, I just started working on some react-accessibility rules, waiting for more feedbacks from our project team.

@HamletDRC
Copy link
Member

OK, I will export this class. I am also working on some React accessibility rules. I would very much like to hear your ideas. I am going to open a different issue and cc you for a discussion!

@ipip2005
Copy link
Collaborator Author

ipip2005 commented Aug 8, 2016

Cool, Great to hear, Thanks!

@HamletDRC
Copy link
Member

OK, the npm package is now on the https://github.com/Microsoft/tslint-microsoft-contrib/tree/releases

Do you need an npm deployment to use this? Or can you point your package.json at this project's releases branch?

@ipip2005
Copy link
Collaborator Author

ipip2005 commented Aug 9, 2016

Perhaps I need a npm deployment to use it for our check-in procedure. I would use this releases branch for testing first.
Thank you so much!

@HamletDRC HamletDRC modified the milestone: 2.0.10 Aug 15, 2016
@HamletDRC HamletDRC changed the title Export TestHelper? Export TestHelper in npm package Aug 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants