Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonarQube fixes #599

Merged
merged 1 commit into from
Jan 18, 2018
Merged

sonarQube fixes #599

merged 1 commit into from
Jan 18, 2018

Conversation

rene-ye
Copy link
Member

@rene-ye rene-ye commented Jan 5, 2018

no functionality changes

@codecov-io
Copy link

codecov-io commented Jan 5, 2018

Codecov Report

Merging #599 into dev will increase coverage by 0.1%.
The diff coverage is 53.48%.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev     #599     +/-   ##
===========================================
+ Coverage     46.54%   46.65%   +0.1%     
- Complexity     2218     2221      +3     
===========================================
  Files           108      108             
  Lines         25335    25314     -21     
  Branches       4177     4175      -2     
===========================================
+ Hits          11792    11809     +17     
+ Misses        11514    11475     -39     
- Partials       2029     2030      +1
Flag Coverage Δ Complexity Δ
#JDBC41 46.46% <53.48%> (+0.18%) 2213 <0> (+4) ⬆️
#JDBC42 46.49% <53.48%> (+0.1%) 2213 <0> (+4) ⬆️
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerResultSetMetaData.java 40.97% <ø> (ø) 23 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerBulkCSVFileRecord.java 45.92% <ø> (ø) 30 <0> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.06% <0%> (+0.17%) 0 <0> (ø) ⬇️
.../java/com/microsoft/sqlserver/jdbc/SqlVariant.java 88.33% <0%> (ø) 13 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 45.98% <100%> (ø) 66 <0> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.02% <100%> (-0.18%) 87 <0> (-1)
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 77% <33.33%> (-0.22%) 25 <0> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.59% <33.33%> (+2.03%) 105 <0> (+2) ⬆️
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 36.15% <63.63%> (+0.63%) 55 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.77% <71.42%> (ø) 278 <0> (ø) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598292b...98182f9. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 6.4.0 milestone Jan 8, 2018
@cheenamalhotra cheenamalhotra merged commit ecf505f into microsoft:dev Jan 18, 2018
@rene-ye rene-ye deleted the sonarQube branch February 6, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants