-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tvp time 4 fix rtw #317
Tvp time 4 fix rtw #317
Conversation
…object, which is converted to String later on and precision is removed.
Codecov Report
@@ Coverage Diff @@
## RTW_6.2.0 #317 +/- ##
===============================================
- Coverage 37.17% 37.15% -0.03%
+ Complexity 1668 1665 -3
===============================================
Files 103 103
Lines 23661 23663 +2
Branches 3917 3918 +1
===============================================
- Hits 8797 8793 -4
- Misses 13273 13277 +4
- Partials 1591 1593 +2
Continue to review full report at Codecov.
|
@@ -112,7 +112,12 @@ boolean isNull() { | |||
Object[] rowData = new Object[colCount]; | |||
for (int i = 0; i < colCount; i++) { | |||
try { | |||
rowData[i] = sourceResultSet.getObject(i + 1); | |||
if (java.sql.Types.TIME == sourceResultSet.getMetaData().getColumnType(i + 1)) { | |||
rowData[i] = sourceResultSet.getTimestamp(i + 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. can you just add a comment explaining why getTimestamp is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I added comment for it. Will merge the PR soon.
for issue #315