-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SonarQube fixes #301
SonarQube fixes #301
Conversation
…e such as "StringBuilder". Remove uselsess assignment to local variable.
…left side of comparison
Codecov Report
@@ Coverage Diff @@
## RTW_6.2.0 #301 +/- ##
===============================================
+ Coverage 37.2% 37.37% +0.17%
- Complexity 1664 1676 +12
===============================================
Files 103 103
Lines 23674 23684 +10
Branches 3882 3880 -2
===============================================
+ Hits 8808 8853 +45
+ Misses 13275 13245 -30
+ Partials 1591 1586 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that 1 change, everything else looks good
@@ -791,7 +792,7 @@ else if (-1 != version.indexOf('.')) { | |||
/* L0 */ public Xid[] recover(int flags) throws XAException { | |||
XAReturnValue r = DTC_XA_Interface(XA_RECOVER, null, flags | tightlyCoupled); | |||
int offset = 0; | |||
Vector<XidImpl> v = new Vector<XidImpl>(); | |||
ArrayList<XidImpl> v = new ArrayList<XidImpl>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the variable name doesnt mean anything anymore now that its an array list instead of a vector. It might be better to rename it to something like al
No description provided.