Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javadoc #299

Merged
merged 3 commits into from
May 19, 2017
Merged

Fix javadoc #299

merged 3 commits into from
May 19, 2017

Conversation

xiangyushawn
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented May 18, 2017

Codecov Report

Merging #299 into RTW_6.2.0 will increase coverage by 0.36%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##             RTW_6.2.0     #299      +/-   ##
===============================================
+ Coverage         37.2%   37.57%   +0.36%     
- Complexity        1664     1693      +29     
===============================================
  Files              103      103              
  Lines            23674    23785     +111     
  Branches          3882     3912      +30     
===============================================
+ Hits              8808     8937     +129     
+ Misses           13275    13245      -30     
- Partials          1591     1603      +12
Flag Coverage Δ Complexity Δ
#JDBC41 37.35% <100%> (+0.23%) 1683 <1> (+23) ⬆️
#JDBC42 37.51% <100%> (+0.39%) 1689 <1> (+29) ⬆️
Impacted Files Coverage Δ Complexity Δ
...com/microsoft/sqlserver/jdbc/dns/DNSUtilities.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 43.92% <ø> (ø) 252 <0> (ø) ⬇️
...com/microsoft/sqlserver/jdbc/dns/DNSRecordSRV.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 51.83% <100%> (+5%) 81 <1> (+17) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 70.03% <0%> (+0.16%) 5% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 37.03% <0%> (+0.2%) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 49.47% <0%> (+0.39%) 213% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 30.13% <0%> (+0.44%) 57% <0%> (+2%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 27.65% <0%> (+0.7%) 191% <0%> (+6%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c85245a...8ce3533. Read the comment docs.

@AfsanehR-zz
Copy link
Contributor

Should we add javadocs for SQLServerDataSource#setQueryTimeout and getQueryTimeout here as well?

@xiangyushawn
Copy link
Contributor Author

xiangyushawn commented May 18, 2017

@v-afrafi agree, also for SQLServerDataSource#setSocketTimeout and getSocketTimeout as well

@AfsanehR-zz AfsanehR-zz self-assigned this May 19, 2017
@xiangyushawn xiangyushawn merged commit 06ff5d0 into microsoft:RTW_6.2.0 May 19, 2017
@xiangyushawn xiangyushawn deleted the fix-javadoc branch May 19, 2017 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants