Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SQLServerException wrapped by another SQLServerException #213

Merged

Conversation

xiangyushawn
Copy link
Contributor

for issue #207

@codecov-io
Copy link

codecov-io commented Mar 21, 2017

Codecov Report

Merging #213 into dev will increase coverage by 0.06%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                dev     #213      +/-   ##
============================================
+ Coverage     32.82%   32.88%   +0.06%     
- Complexity     1436     1442       +6     
============================================
  Files            97       97              
  Lines         23383    23385       +2     
  Branches       3889     3889              
============================================
+ Hits           7675     7691      +16     
+ Misses        14163    14151      -12     
+ Partials       1545     1543       -2
Flag Coverage Δ Complexity Δ
#JDBC41 32.69% <100%> (+0.03%) 1429 <0> (+3) ⬆️
#JDBC42 32.85% <100%> (+0.11%) 1442 <0> (+8) ⬆️
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 20.13% <100%> (+0.35%) 27 <0> (ø) ⬇️
src/main/java/microsoft/sql/DateTimeOffset.java 37.14% <0%> (-2.86%) 8% <0%> (-2%)
...t/sqlserver/jdbc/SQLServerConnectionPoolProxy.java 12.62% <0%> (ø) 12% <0%> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 36.41% <0%> (+0.06%) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 45.01% <0%> (+0.21%) 184% <0%> (+3%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 24.33% <0%> (+0.44%) 175% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4d62b...4845965. Read the comment docs.

Copy link
Contributor

@v-nisidh v-nisidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@@ -628,6 +628,9 @@ private void checkClosed() throws SQLServerException {
}
}
}
catch (SQLServerException e) {
throw e;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add one line comment like SQLServerException should not again wrapped by SQLServerException

@xiangyushawn xiangyushawn merged commit 6e66442 into microsoft:dev Mar 22, 2017
@xiangyushawn xiangyushawn deleted the SQLServerException-thrown-twice branch March 22, 2017 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants